From aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 4 Jun 2021 14:41:53 -0700 Subject: [PATCH] [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() This diff adds testcase for the issue fixed in https://reviews.llvm.org/D77468 but regression test was not added in the diff. On Clang 9 it caused crash in cland during code completion. Test Plan: check-clang-unit Differential Revision: https://reviews.llvm.org/D103722 --- clang/unittests/AST/CommentTextTest.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/clang/unittests/AST/CommentTextTest.cpp b/clang/unittests/AST/CommentTextTest.cpp index 3de6758..b697828 100644 --- a/clang/unittests/AST/CommentTextTest.cpp +++ b/clang/unittests/AST/CommentTextTest.cpp @@ -124,4 +124,11 @@ R"cpp( // clang-format on } +TEST_F(CommentTextTest, EmptyFormattedText) { + // Test that empty formatted text doesn't cause crash. + const char *ExpectedOutput = ""; + auto Formatted = formatComment("//!<"); + EXPECT_EQ(ExpectedOutput, Formatted); +} + } // namespace clang -- 2.7.4