From a9babe8053e296a8032ead1efebe99f43c09b7e2 Mon Sep 17 00:00:00 2001
From: Savio Sena <savio@expertisesolutions.com.br>
Date: Sat, 10 May 2014 10:15:33 +0200
Subject: [PATCH] eolian-cxx: remove annoying compilation warnings and messages

Summary:
- remove an automake warning caused by a variable redefinition
- remove unnecessary verbosity during debug compilation

Reviewers: cedric, smohanty

CC: felipealmeida, cedric

Differential Revision: https://phab.enlightenment.org/D844

Signed-off-by: Cedric Bail <cedric.bail@free.fr>
---
 src/examples/eolian_cxx/Makefile.am |  1 -
 src/lib/eolian_cxx/eo_validate.hh   | 23 -----------------------
 2 files changed, 24 deletions(-)

diff --git a/src/examples/eolian_cxx/Makefile.am b/src/examples/eolian_cxx/Makefile.am
index 3d126df..09b770a 100644
--- a/src/examples/eolian_cxx/Makefile.am
+++ b/src/examples/eolian_cxx/Makefile.am
@@ -83,7 +83,6 @@ EXTRA_PROGRAMS = \
 	eolian_cxx_inherit_01
 
 DATA_FILES = Makefile.examples $(EOS)
-CLEANFILES =
 
 eolian_cxx_simple_01_SOURCES = \
 	eolian_cxx_simple_01.cc \
diff --git a/src/lib/eolian_cxx/eo_validate.hh b/src/lib/eolian_cxx/eo_validate.hh
index 9345ddb..ab28c2f 100644
--- a/src/lib/eolian_cxx/eo_validate.hh
+++ b/src/lib/eolian_cxx/eo_validate.hh
@@ -19,26 +19,11 @@ _isvalid(const std::string& name)
    return name.size() > 0 and isalpha(name[0]);
 }
 
-#ifdef DEBUG
-inline void
-_dbg(const std::string& msg)
-{
-   std::cerr << "eo_validate() - " << msg << std::endl;
-}
-#else
-inline void
-_dbg(const std::string&)
-{
-}
-#endif
-
 inline void
 eo_class_validate(const eo_class& cls)
 {
-   _dbg("class name... " + cls.name);
    assert(_isvalid(cls.name));
 
-   _dbg("class type... " + cls.type);
    assert(cls.type != eo_class::regular_ ||
           cls.type != eo_class::regular_noninst_ ||
           cls.type != eo_class::interface_ ||
@@ -53,13 +38,10 @@ eo_class_validate(const eo_class& cls)
            parameters_container_type::const_iterator
              param = (*it).params.begin(),
              last_param = (*it).params.end();
-           _dbg("constructor... " + (*it).name);
            assert(_isvalid((*it).name));
            for (; param != last_param; ++param)
              {
-                _dbg("constructor parameter... " + (*param).name);
                 assert(_isvalid((*param).name));
-                _dbg("constructor parameter type... " + (*param).type);
                 assert(_isvalid((*param).type));
              }
         }
@@ -71,20 +53,15 @@ eo_class_validate(const eo_class& cls)
         last  = cls.functions.end();
       for (it = first; it != last; ++it)
         {
-           _dbg("function... " + (*it).name);
            assert(_isvalid((*it).name));
-           _dbg("function api... " + (*it).impl);
            assert(_isvalid((*it).impl));
-           _dbg("function return... " + (*it).ret);
            assert(_isvalid((*it).ret));
            parameters_container_type::const_iterator
              param = (*it).params.begin(),
              last_param = (*it).params.end();
            for (; param != last_param; ++param)
              {
-                _dbg("function parameter... " + (*param).name);
                 assert(_isvalid((*param).name));
-                _dbg("function parameter type... " + (*param).type);
                 assert(_isvalid((*param).type));
              }
         }
-- 
2.7.4