From a951e8ece71b6393b602fd3d5f3538a264508673 Mon Sep 17 00:00:00 2001 From: Xinliang David Li Date: Tue, 9 Feb 2016 20:02:59 +0000 Subject: [PATCH] [PGO] Fix issue: explicitly defaulted assignop is not profiled Differential Revision: http://reviews.llvm.org/D16947 llvm-svn: 260270 --- clang/lib/CodeGen/CGClass.cpp | 1 + clang/test/Profile/def-assignop.cpp | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 clang/test/Profile/def-assignop.cpp diff --git a/clang/lib/CodeGen/CGClass.cpp b/clang/lib/CodeGen/CGClass.cpp index 2adb74a..122f2f8 100644 --- a/clang/lib/CodeGen/CGClass.cpp +++ b/clang/lib/CodeGen/CGClass.cpp @@ -1608,6 +1608,7 @@ void CodeGenFunction::emitImplicitAssignmentOperatorBody(FunctionArgList &Args) LexicalScope Scope(*this, RootCS->getSourceRange()); + incrementProfileCounter(RootCS); AssignmentMemcpyizer AM(*this, AssignOp, Args); for (auto *I : RootCS->body()) AM.emitAssignment(I); diff --git a/clang/test/Profile/def-assignop.cpp b/clang/test/Profile/def-assignop.cpp new file mode 100644 index 0000000..50537f0 --- /dev/null +++ b/clang/test/Profile/def-assignop.cpp @@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang | FileCheck --check-prefix=PGOGEN %s +// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang -fcoverage-mapping | FileCheck --check-prefix=COVMAP %s + +struct B { + B& operator=(const B &b); + B& operator=(const B &&b); +}; + +struct A { + A &operator=(const A &) = default; + // PGOGEN: define {{.*}}@_ZN1AaSERKS_( + // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSERKS_ + // PGOGEN: {{.*}}add{{.*}}%pgocount, 1 + // PGOGEN: store{{.*}}@__profc__ZN1AaSERKS_ + A &operator=(A &&) = default; + // PGOGEN: define {{.*}}@_ZN1AaSEOS_ + // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSEOS_ + // PGOGEN: {{.*}}add{{.*}}%pgocount, 1 + // PGOGEN: store{{.*}}@__profc__ZN1AaSEOS_ + + // Check that coverage mapping includes 6 function records including the + // defaulted copy and move operators: A::operator= + // COVMAP: @__llvm_coverage_mapping = {{.*}} { { i32, i32, i32, i32 }, [3 x <{{.*}}>], + B b; +}; + +int main() { + A a1, a2; + a1 = a2; + a2 = static_cast(a1); + return 0; +} -- 2.7.4