From a92326b6cbdfb5a74b87b7b2a4398f34597fb120 Mon Sep 17 00:00:00 2001 From: jgreenhalgh Date: Thu, 25 Sep 2014 16:54:38 +0000 Subject: [PATCH] [AArch64] Tighten predicates on SIMD shift intrinsics gcc/ * config/aarch64/aarch64-protos.h (aarch64_simd_const_bounds): Delete. * config/aarch64/aarch64-simd.md (aarch64_qshl): Use new predicates. (aarch64_shll2_n): Likewise. (aarch64_shr_n): Likewise. (aarch64_sra_n: Likewise. (aarch64_si_n): Likewise. (aarch64_qshl_n): Likewise. * config/aarch64/aarch64.c (aarch64_simd_const_bounds): Delete. * config/aarch64/iterators.md (ve_mode): New. (offsetlr): Remap to infix text for use in new predicates. * config/aarch64/predicates.md (aarch64_simd_shift_imm_qi): New. (aarch64_simd_shift_imm_hi): Likewise. (aarch64_simd_shift_imm_si): Likewise. (aarch64_simd_shift_imm_di): Likewise. (aarch64_simd_shift_imm_offset_qi): Likewise. (aarch64_simd_shift_imm_offset_hi): Likewise. (aarch64_simd_shift_imm_offset_si): Likewise. (aarch64_simd_shift_imm_offset_di): Likewise. (aarch64_simd_shift_imm_bitsize_qi): Likewise. (aarch64_simd_shift_imm_bitsize_hi): Likewise. (aarch64_simd_shift_imm_bitsize_si): Likewise. (aarch64_simd_shift_imm_bitsize_di): Likewise. gcc/testsuite/ * gcc.target/aarch64/simd/vqshlb_1.c: New. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@215612 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 26 ++++++++++++ gcc/config/aarch64/aarch64-protos.h | 1 - gcc/config/aarch64/aarch64-simd.md | 46 ++++++++------------ gcc/config/aarch64/aarch64.c | 10 ----- gcc/config/aarch64/iterators.md | 13 +++++- gcc/config/aarch64/predicates.md | 53 ++++++++++++++++++++++++ gcc/testsuite/ChangeLog | 4 ++ gcc/testsuite/gcc.target/aarch64/simd/vqshlb_1.c | 21 ++++++++++ 8 files changed, 132 insertions(+), 42 deletions(-) create mode 100644 gcc/testsuite/gcc.target/aarch64/simd/vqshlb_1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c3533ef..8d2c5dd 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,29 @@ +2014-09-25 James Greenhalgh + + * config/aarch64/aarch64-protos.h (aarch64_simd_const_bounds): Delete. + * config/aarch64/aarch64-simd.md (aarch64_qshl): Use + new predicates. + (aarch64_shll2_n): Likewise. + (aarch64_shr_n): Likewise. + (aarch64_sra_n: Likewise. + (aarch64_si_n): Likewise. + (aarch64_qshl_n): Likewise. + * config/aarch64/aarch64.c (aarch64_simd_const_bounds): Delete. + * config/aarch64/iterators.md (ve_mode): New. + (offsetlr): Remap to infix text for use in new predicates. + * config/aarch64/predicates.md (aarch64_simd_shift_imm_qi): New. + (aarch64_simd_shift_imm_hi): Likewise. + (aarch64_simd_shift_imm_si): Likewise. + (aarch64_simd_shift_imm_di): Likewise. + (aarch64_simd_shift_imm_offset_qi): Likewise. + (aarch64_simd_shift_imm_offset_hi): Likewise. + (aarch64_simd_shift_imm_offset_si): Likewise. + (aarch64_simd_shift_imm_offset_di): Likewise. + (aarch64_simd_shift_imm_bitsize_qi): Likewise. + (aarch64_simd_shift_imm_bitsize_hi): Likewise. + (aarch64_simd_shift_imm_bitsize_si): Likewise. + (aarch64_simd_shift_imm_bitsize_di): Likewise. + 2014-09-25 Jiong Wang * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the live-in of diff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h index e32ef64..b5f53d2 100644 --- a/gcc/config/aarch64/aarch64-protos.h +++ b/gcc/config/aarch64/aarch64-protos.h @@ -256,7 +256,6 @@ void aarch64_emit_call_insn (rtx); /* Initialize builtins for SIMD intrinsics. */ void init_aarch64_simd_builtins (void); -void aarch64_simd_const_bounds (rtx, HOST_WIDE_INT, HOST_WIDE_INT); void aarch64_simd_disambiguate_copy (rtx *, rtx *, rtx *, unsigned int); /* Emit code to place a AdvSIMD pair result in memory locations (with equal diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md index 493e886..8b7923e 100644 --- a/gcc/config/aarch64/aarch64-simd.md +++ b/gcc/config/aarch64/aarch64-simd.md @@ -3607,12 +3607,12 @@ (define_insn "aarch64_shll_n" [(set (match_operand: 0 "register_operand" "=w") (unspec: [(match_operand:VDW 1 "register_operand" "w") - (match_operand:SI 2 "immediate_operand" "i")] + (match_operand:SI 2 + "aarch64_simd_shift_imm_bitsize_" "i")] VSHLL))] "TARGET_SIMD" "* int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[2], 0, bit_width + 1); if (INTVAL (operands[2]) == bit_width) { return \"shll\\t%0., %1., %2\"; @@ -3633,7 +3633,6 @@ "TARGET_SIMD" "* int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[2], 0, bit_width + 1); if (INTVAL (operands[2]) == bit_width) { return \"shll2\\t%0., %1., %2\"; @@ -3649,13 +3648,11 @@ (define_insn "aarch64_shr_n" [(set (match_operand:VSDQ_I_DI 0 "register_operand" "=w") (unspec:VSDQ_I_DI [(match_operand:VSDQ_I_DI 1 "register_operand" "w") - (match_operand:SI 2 "immediate_operand" "i")] + (match_operand:SI 2 + "aarch64_simd_shift_imm_offset_" "i")] VRSHR_N))] "TARGET_SIMD" - "* - int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[2], 1, bit_width + 1); - return \"shr\\t%0, %1, %2\";" + "shr\\t%0, %1, %2" [(set_attr "type" "neon_sat_shift_imm")] ) @@ -3665,13 +3662,11 @@ [(set (match_operand:VSDQ_I_DI 0 "register_operand" "=w") (unspec:VSDQ_I_DI [(match_operand:VSDQ_I_DI 1 "register_operand" "0") (match_operand:VSDQ_I_DI 2 "register_operand" "w") - (match_operand:SI 3 "immediate_operand" "i")] + (match_operand:SI 3 + "aarch64_simd_shift_imm_offset_" "i")] VSRA))] "TARGET_SIMD" - "* - int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[3], 1, bit_width + 1); - return \"sra\\t%0, %2, %3\";" + "sra\\t%0, %2, %3" [(set_attr "type" "neon_shift_acc")] ) @@ -3681,14 +3676,11 @@ [(set (match_operand:VSDQ_I_DI 0 "register_operand" "=w") (unspec:VSDQ_I_DI [(match_operand:VSDQ_I_DI 1 "register_operand" "0") (match_operand:VSDQ_I_DI 2 "register_operand" "w") - (match_operand:SI 3 "immediate_operand" "i")] + (match_operand:SI 3 + "aarch64_simd_shift_imm_" "i")] VSLRI))] "TARGET_SIMD" - "* - int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[3], 1 - , - bit_width - + 1); - return \"si\\t%0, %2, %3\";" + "si\\t%0, %2, %3" [(set_attr "type" "neon_shift_imm")] ) @@ -3697,13 +3689,11 @@ (define_insn "aarch64_qshl_n" [(set (match_operand:VSDQ_I 0 "register_operand" "=w") (unspec:VSDQ_I [(match_operand:VSDQ_I 1 "register_operand" "w") - (match_operand:SI 2 "immediate_operand" "i")] + (match_operand:SI 2 + "aarch64_simd_shift_imm_" "i")] VQSHL_N))] "TARGET_SIMD" - "* - int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[2], 0, bit_width); - return \"qshl\\t%0, %1, %2\";" + "qshl\\t%0, %1, %2" [(set_attr "type" "neon_sat_shift_imm")] ) @@ -3713,13 +3703,11 @@ (define_insn "aarch64_qshrn_n" [(set (match_operand: 0 "register_operand" "=w") (unspec: [(match_operand:VSQN_HSDI 1 "register_operand" "w") - (match_operand:SI 2 "immediate_operand" "i")] + (match_operand:SI 2 + "aarch64_simd_shift_imm_offset_" "i")] VQSHRN_N))] "TARGET_SIMD" - "* - int bit_width = GET_MODE_UNIT_SIZE (mode) * BITS_PER_UNIT; - aarch64_simd_const_bounds (operands[2], 1, bit_width + 1); - return \"qshrn\\t%0, %1, %2\";" + "qshrn\\t%0, %1, %2" [(set_attr "type" "neon_sat_shift_imm_narrow_q")] ) diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 4e0cba8..68c78f6 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -7988,16 +7988,6 @@ aarch64_simd_lane_bounds (rtx operand, HOST_WIDE_INT low, HOST_WIDE_INT high) error ("lane out of range"); } -void -aarch64_simd_const_bounds (rtx operand, HOST_WIDE_INT low, HOST_WIDE_INT high) -{ - gcc_assert (CONST_INT_P (operand)); - HOST_WIDE_INT lane = INTVAL (operand); - - if (lane < low || lane >= high) - error ("constant out of range"); -} - /* Emit code to place a AdvSIMD pair result in memory locations (with equal registers). */ void diff --git a/gcc/config/aarch64/iterators.md b/gcc/config/aarch64/iterators.md index daa5d9f..efd006f 100644 --- a/gcc/config/aarch64/iterators.md +++ b/gcc/config/aarch64/iterators.md @@ -538,6 +538,14 @@ (V2DF "v2di") (DF "di") (SF "si")]) +;; Lower case element modes (as used in shift immediate patterns). +(define_mode_attr ve_mode [(V8QI "qi") (V16QI "qi") + (V4HI "hi") (V8HI "hi") + (V2SI "si") (V4SI "si") + (DI "di") (V2DI "di") + (QI "qi") (HI "hi") + (SI "si")]) + ;; Vm for lane instructions is restricted to FP_LO_REGS. (define_mode_attr vwx [(V4HI "x") (V8HI "x") (HI "x") (V2SI "w") (V4SI "w") (SI "w")]) @@ -1007,8 +1015,9 @@ (UNSPEC_RADDHN2 "add") (UNSPEC_RSUBHN2 "sub")]) -(define_int_attr offsetlr [(UNSPEC_SSLI "1") (UNSPEC_USLI "1") - (UNSPEC_SSRI "0") (UNSPEC_USRI "0")]) +(define_int_attr offsetlr [(UNSPEC_SSLI "") (UNSPEC_USLI "") + (UNSPEC_SSRI "offset_") + (UNSPEC_USRI "offset_")]) ;; Standard pattern names for floating-point rounding instructions. (define_int_attr frint_pattern [(UNSPEC_FRINTZ "btrunc") diff --git a/gcc/config/aarch64/predicates.md b/gcc/config/aarch64/predicates.md index 8191169..d5b0b2a 100644 --- a/gcc/config/aarch64/predicates.md +++ b/gcc/config/aarch64/predicates.md @@ -279,3 +279,56 @@ { return aarch64_const_vec_all_same_int_p (op, -1); }) + +;; Predicates used by the various SIMD shift operations. These +;; fall in to 3 categories. +;; Shifts with a range 0-(bit_size - 1) (aarch64_simd_shift_imm) +;; Shifts with a range 1-bit_size (aarch64_simd_shift_imm_offset) +;; Shifts with a range 0-bit_size (aarch64_simd_shift_imm_bitsize) +(define_predicate "aarch64_simd_shift_imm_qi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 7)"))) + +(define_predicate "aarch64_simd_shift_imm_hi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 15)"))) + +(define_predicate "aarch64_simd_shift_imm_si" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 31)"))) + +(define_predicate "aarch64_simd_shift_imm_di" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 63)"))) + +(define_predicate "aarch64_simd_shift_imm_offset_qi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 1, 8)"))) + +(define_predicate "aarch64_simd_shift_imm_offset_hi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 1, 16)"))) + +(define_predicate "aarch64_simd_shift_imm_offset_si" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 1, 32)"))) + +(define_predicate "aarch64_simd_shift_imm_offset_di" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 1, 64)"))) + +(define_predicate "aarch64_simd_shift_imm_bitsize_qi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 8)"))) + +(define_predicate "aarch64_simd_shift_imm_bitsize_hi" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 16)"))) + +(define_predicate "aarch64_simd_shift_imm_bitsize_si" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 32)"))) + +(define_predicate "aarch64_simd_shift_imm_bitsize_di" + (and (match_code "const_int") + (match_test "IN_RANGE (INTVAL (op), 0, 64)"))) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 9c7c3c9..1ac6f0e 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2014-09-25 James Greenhalgh + + * gcc.target/aarch64/simd/vqshlb_1.c: New. + 2014-09-25 Jiong Wang * gcc.target/i386/shrink_wrap_1.c: New test. diff --git a/gcc/testsuite/gcc.target/aarch64/simd/vqshlb_1.c b/gcc/testsuite/gcc.target/aarch64/simd/vqshlb_1.c new file mode 100644 index 0000000..ae741de --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/simd/vqshlb_1.c @@ -0,0 +1,21 @@ +/* { dg-do run } */ +/* { dg-options "-O3" } */ + +#include "arm_neon.h" + +extern void abort (); + +int +main (int argc, char **argv) +{ + int8_t arg1 = -1; + int8_t arg2 = 127; + int8_t exp = -128; + int8_t got = vqshlb_s8 (arg1, arg2); + + if (exp != got) + abort (); + + return 0; +} + -- 2.7.4