From a8f18aef189e31edeac9cab2a746d8199b9e73c2 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Sun, 29 May 2022 20:27:38 +1000 Subject: [PATCH] rtpptdemux: Don't GST_FLOW_ERROR when ignoring invalid packets https://bugzilla.gnome.org/show_bug.cgi?id=741398 changed rtpptdemux in 2014 to not post a GST_ELEMENT_ERROR on the bus when dropping an invalid (non-RTP) packet, but still returned GST_FLOW_ERROR upstream - so the pipeline still stops, but now without a useful bus error. Return GST_FLOW_OK instead, so the pipeline keeps running. Some old telephony equipment can send invalid packets before the real RTP traffic starts. Part-of: --- subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c index 6759e69..5cbbc72 100644 --- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c +++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpptdemux.c @@ -567,7 +567,7 @@ invalid_buffer: GST_ELEMENT_WARNING (rtpdemux, STREAM, DEMUX, (NULL), ("Dropping invalid RTP payload")); gst_buffer_unref (buf); - return GST_FLOW_ERROR; + return GST_FLOW_OK; } no_caps: { -- 2.7.4