From a88b64b9bbf8b2a315206e211250c5529534a477 Mon Sep 17 00:00:00 2001 From: Tulio Magno Quites Machado Filho Date: Fri, 18 May 2012 08:50:33 -0500 Subject: [PATCH] [PowerPC] Remove -ftree-loop-linear from Makefiles In the past the "-ftree-loop-linear" switch provided a measurable improvement in performance for certain functions. At some point it was assigned as the responsibility of Graphite in GCC. It has been found that even with Graphite enabled these flags no longer perform any appreciable improvement over the baseline. Graphite now has some open bugs which need to be fixed in order for it to provide measurable performance improvements but it lacks active development. As a result some compiler distributors may disable Graphite. If Graphite is disabled then building GLIBC will fail if the "-ftree-loop-linear" switch is used. This patch removes the use of "-ftree-loop-linear" as unnecessary. --- ChangeLog | 12 ++++++++++++ sysdeps/powerpc/powerpc32/power4/Makefile | 4 ++-- sysdeps/powerpc/powerpc32/power4/fpu/Makefile | 2 +- sysdeps/powerpc/powerpc64/power4/Makefile | 4 ++-- sysdeps/powerpc/powerpc64/power4/fpu/Makefile | 2 +- 5 files changed, 18 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 50bc035..9d07286 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2012-05-18 Tulio Magno Quites Machado Filho + + * sysdeps/powerpc/powerpc32/power4/Makefile (CFLAGS-wordcopy.c, + CFLAGS-memmove.c): remove -ftree-loop-linear which causes a build + failure if the compiler has Graphite support disabled. + * sysdeps/powerpc/powerpc32/power4/fpu/Makefile (CFLAGS-mpa.c): + Likewise. + * sysdeps/powerpc/powerpc64/power4/Makefile (CFLAGS-wordcopy.c, + CFLAGS-memmove.c): Likewise. + * sysdeps/powerpc/powerpc64/power4/fpu/Makefile (CFLAGS-mpa.c): + Likewise. + 2012-05-18 H.J. Lu * sysdeps/x86_64/x32/_itoa.h: New file. diff --git a/sysdeps/powerpc/powerpc32/power4/Makefile b/sysdeps/powerpc/powerpc32/power4/Makefile index 60aa508..ba06adb 100644 --- a/sysdeps/powerpc/powerpc32/power4/Makefile +++ b/sysdeps/powerpc/powerpc32/power4/Makefile @@ -1,6 +1,6 @@ # Makefile fragment for POWER4/5/5+. ifeq ($(subdir),string) -CFLAGS-wordcopy.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops -ftree-loop-linear -CFLAGS-memmove.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops -ftree-loop-linear +CFLAGS-wordcopy.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops +CFLAGS-memmove.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops endif diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/Makefile index a6fa75e..f487ed6 100644 --- a/sysdeps/powerpc/powerpc32/power4/fpu/Makefile +++ b/sysdeps/powerpc/powerpc32/power4/fpu/Makefile @@ -1,5 +1,5 @@ # Makefile fragment for POWER4/5/5+ with FPU. ifeq ($(subdir),math) -CFLAGS-mpa.c += --param max-unroll-times=4 -funroll-loops -fpeel-loops -ftree-loop-linear +CFLAGS-mpa.c += --param max-unroll-times=4 -funroll-loops -fpeel-loops endif diff --git a/sysdeps/powerpc/powerpc64/power4/Makefile b/sysdeps/powerpc/powerpc64/power4/Makefile index 60aa508..ba06adb 100644 --- a/sysdeps/powerpc/powerpc64/power4/Makefile +++ b/sysdeps/powerpc/powerpc64/power4/Makefile @@ -1,6 +1,6 @@ # Makefile fragment for POWER4/5/5+. ifeq ($(subdir),string) -CFLAGS-wordcopy.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops -ftree-loop-linear -CFLAGS-memmove.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops -ftree-loop-linear +CFLAGS-wordcopy.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops +CFLAGS-memmove.c += --param max-variable-expansions-in-unroller=2 --param max-unroll-times=2 -funroll-loops -fpeel-loops endif diff --git a/sysdeps/powerpc/powerpc64/power4/fpu/Makefile b/sysdeps/powerpc/powerpc64/power4/fpu/Makefile index 89dfa5e..f8bb3ef 100644 --- a/sysdeps/powerpc/powerpc64/power4/fpu/Makefile +++ b/sysdeps/powerpc/powerpc64/power4/fpu/Makefile @@ -1,5 +1,5 @@ # Makefile fragment for POWER4/5/5+ platforms with FPU. ifeq ($(subdir),math) -CFLAGS-mpa.c += --param max-unroll-times=4 -funroll-loops -fpeel-loops -ftree-loop-linear +CFLAGS-mpa.c += --param max-unroll-times=4 -funroll-loops -fpeel-loops endif -- 2.7.4