From a8377402ee626bd0a6c61ef9f0c256f06eca5759 Mon Sep 17 00:00:00 2001 From: tomhudson Date: Fri, 27 Jun 2014 08:19:35 -0700 Subject: [PATCH] Mark SkBBoxHierarchyRecord destructor as virtual Immediate parent classes have empty virtual destructors, but farther up the inheritance tree there is complicated destruction going on. This change may be unnecessary but makes the polymorphism explicit. BUG=skia:1734 R=mtklein@google.com, tomhudson@google.com, mtklein Author: tomhudson@chromium.org Review URL: https://codereview.chromium.org/359773002 --- src/core/SkBBoxHierarchyRecord.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/SkBBoxHierarchyRecord.h b/src/core/SkBBoxHierarchyRecord.h index 51fce0d8bc..ba7d514bc5 100644 --- a/src/core/SkBBoxHierarchyRecord.h +++ b/src/core/SkBBoxHierarchyRecord.h @@ -20,6 +20,7 @@ class SkBBoxHierarchyRecord : public SkBBoxRecord, public SkBBoxHierarchyClient public: /** This will take a ref of h */ SkBBoxHierarchyRecord(const SkISize& size, uint32_t recordFlags, SkBBoxHierarchy* h); + virtual ~SkBBoxHierarchyRecord() { }; virtual void handleBBox(const SkRect& bounds) SK_OVERRIDE; -- 2.34.1