From a81bdc614a7d79fb9dc54e234b6704f190f588e6 Mon Sep 17 00:00:00 2001 From: Aaron Siddhartha Mondal Date: Thu, 23 Feb 2023 01:52:02 +0100 Subject: [PATCH] [bazel] Remove unused dependency on libxml2 The Bazel configs don't set `LLVM_ENABLE_LIBXML2`, so this was never usable to begin with. On systems without static `libxml2.a` this made `lld` runtime-dependent on an unused, non-hermetic `libxml2.so`. Reviewed By: MaskRay, GMNGeoffrey Differential Revision: https://reviews.llvm.org/D143351 --- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel | 5 ----- 1 file changed, 5 deletions(-) diff --git a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel index 2b88729..5f5fb34 100644 --- a/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel @@ -2762,11 +2762,6 @@ cc_library( "include/llvm/WindowsManifest/*.h", ]), copts = llvm_copts, - linkopts = [ - # Libxml2 is required to process Windows manifests. Without this, - # lld uses Microsoft mt.exe instead, which is not cross-platform. - "-lxml2", - ], deps = [ ":Support", ":config", -- 2.7.4