From a80b73f6a8a2a81ab567f869c8d5d173045d9b3b Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EB=B0=95=EC=84=B8=ED=9D=AC/On-Device=20Lab=28SR=29/Princip?= =?utf8?q?al=20Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Tue, 13 Aug 2019 10:47:12 +0900 Subject: [PATCH] [moco-tf] Clear ConcatV2 import test (#6522) This will erase ConcatV2 TF dialect import test to reduce complexity of diff for migration to using VariadicArityNode Signed-off-by: SaeHie Park --- compiler/moco-tf/src/Op/Concat.test.cpp | 80 ++------------------------------- 1 file changed, 3 insertions(+), 77 deletions(-) diff --git a/compiler/moco-tf/src/Op/Concat.test.cpp b/compiler/moco-tf/src/Op/Concat.test.cpp index 339a8ca..53daa63 100644 --- a/compiler/moco-tf/src/Op/Concat.test.cpp +++ b/compiler/moco-tf/src/Op/Concat.test.cpp @@ -193,28 +193,7 @@ TEST(TensorFlowImport, concat_01) } // Test "ConcatV2GraphBuilderImpl" - { - // what to test: - // - there should exist TensorConcat - // - lhs() should not be nullptr - // - rhs() should not be nullptr - // - axis() should match - - using ConcatV2GraphBuilder = ConcatV2GraphBuilderImpl; - - moco::tf::GraphBuilderRegistry r{&moco::tf::GraphBuilderRegistry::get()}; - r.add("ConcatV2", stdex::make_unique()); - moco::tf::Importer importer{&r}; - - std::unique_ptr graph = importer.import(signature, graph_def); - - auto concat_node = moco::tf::test::find_first_node_bytype(graph.get()); - - ASSERT_NE(concat_node, nullptr); - ASSERT_NE(concat_node->lhs(), nullptr); - ASSERT_NE(concat_node->rhs(), nullptr); - ASSERT_EQ(concat_node->axis(), 0); - } + // TODO implement test } namespace @@ -422,39 +401,7 @@ TEST(TensorFlowImport, concat_02) } // Test "ConcatV2GraphBuilderImpl" - { - // what to test: Concat has 3 inputs --> Importer creates 2 TFConcatV2 - // - there should exist two TFConcatV2 - // - lhs() of #1 should not be nullptr - // - rhs() of #1 should not be nullptr - // - lhs() of #2 should be #1 - // - rhs() of #2 should not be nullptr - // - axis() should match - - using ConcatV2GraphBuilder = ConcatV2GraphBuilderImpl; - - moco::tf::GraphBuilderRegistry r{&moco::tf::GraphBuilderRegistry::get()}; - r.add("ConcatV2", stdex::make_unique()); - moco::tf::Importer importer{&r}; - - std::unique_ptr graph = importer.import(signature, graph_def); - - std::vector concat_nodes = - moco::tf::test::find_nodes_bytype(graph.get()); - ASSERT_EQ(concat_nodes.size(), 2); - moco::tf::TFConcatV2 *concat_node0 = concat_nodes.at(0); - moco::tf::TFConcatV2 *concat_node1 = concat_nodes.at(1); - - ASSERT_NE(concat_node0, nullptr); - ASSERT_NE(concat_node1, nullptr); - ASSERT_NE(concat_node0->lhs(), nullptr); - ASSERT_NE(concat_node0->rhs(), nullptr); - ASSERT_NE(concat_node1->lhs(), nullptr); - ASSERT_NE(concat_node1->rhs(), nullptr); - ASSERT_TRUE(concat_node0->lhs() == concat_node1 || concat_node1->lhs() == concat_node0); - ASSERT_EQ(concat_node0->axis(), 0); - ASSERT_EQ(concat_node1->axis(), 0); - } + // TODO implement test } namespace @@ -601,26 +548,5 @@ TEST(TensorFlowImport, concat_03) } // Test "ConcatV2GraphBuilderImpl" - { - // what to test: minus axis value validation - // - there should exist a TFConcatV2 - // - lhs() should not be nullptr - // - rhs() should not be nullptr - // - axis() should match 2 + (-1), where 2 came from rank of input(s) - - using ConcatV2GraphBuilder = ConcatV2GraphBuilderImpl; - - moco::tf::GraphBuilderRegistry r{&moco::tf::GraphBuilderRegistry::get()}; - r.add("ConcatV2", stdex::make_unique()); - moco::tf::Importer importer{&r}; - - std::unique_ptr graph = importer.import(signature, graph_def); - - auto concat_node = moco::tf::test::find_first_node_bytype(graph.get()); - - ASSERT_NE(concat_node, nullptr); - ASSERT_NE(concat_node->lhs(), nullptr); - ASSERT_NE(concat_node->rhs(), nullptr); - ASSERT_EQ(concat_node->axis(), (2 + (-1))); - } + // TODO implement test } -- 2.7.4