From a7afd0017996d4b457a84b6cd342cee47cd3d81d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Olivier=20Cr=C3=AAte?= Date: Thu, 9 Oct 2014 16:21:18 -0400 Subject: [PATCH] agent: Pass all packets that are not acceptable STUN packets to the application We attempted to not pass through some packets that looked like valid STUN but were ot acceptable to us, but that dropped some application packets. --- agent/agent.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/agent/agent.c b/agent/agent.c index 91ea10b..886d5ec 100644 --- a/agent/agent.c +++ b/agent/agent.c @@ -3531,18 +3531,13 @@ agent_recv_message_unlocked ( if (handled) { /* Handled STUN message. */ nice_debug ("%s: Valid STUN packet received.", G_STRFUNC); - } else { - /* Valid but unhandled STUN message (e.g. does not match a previously - * sent request due to being a duplicate response). */ - nice_debug ("%s: Valid but unhandled STUN packet received.", G_STRFUNC); + retval = RECV_OOB; + g_free (big_buf); + goto done; } - - retval = RECV_OOB; - g_free (big_buf); - goto done; } - nice_debug ("%s: WARNING: Packet passed fast STUN validation but failed " + nice_debug ("%s: Packet passed fast STUN validation but failed " "slow validation.", G_STRFUNC); g_free (big_buf); -- 2.7.4