From a75140ba871aae590dc37c08a8e5357ef5e746ea Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Fri, 30 Jun 2023 18:30:46 +0100 Subject: [PATCH] webrtcstats: Properly report IceCandidate type strcmp returns a positive value if s1 is greater than s2, while we actually needed to check equality here. Part-of: --- subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c index db922f0..153ade6 100644 --- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c +++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcstats.c @@ -581,9 +581,9 @@ _get_stats_from_ice_candidates (GstWebRTCBin * webrtc, can->stream_id, can->ipaddr, can->port); stats = gst_structure_new_empty (id); - if (strcmp (candidate_tag, "local")) { + if (g_str_equal (candidate_tag, "local")) { type = GST_WEBRTC_STATS_LOCAL_CANDIDATE; - } else if (strcmp (candidate_tag, "remote")) { + } else if (g_str_equal (candidate_tag, "remote")) { type = GST_WEBRTC_STATS_REMOTE_CANDIDATE; } else { GST_WARNING_OBJECT (webrtc, "Invalid ice candidate tag: %s", candidate_tag); -- 2.7.4