From a71f55c482ada2c6c31d450ac22494b547512127 Mon Sep 17 00:00:00 2001 From: Uros Bizjak Date: Thu, 20 May 2021 18:48:16 +0200 Subject: [PATCH] i386: Avoid integer logic insns for 32bit and 64bit vector modes [PR100701] MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Integer logic instructions clobber flags, do not use them for 32bit and 64bit vector modes. 2021-05-20 Uroš Bizjak gcc/ PR target/100701 * config/i386/i386.md (isa): Remove x64_bmi. (enabled): Remove x64_bmi. * config/i386/mmx.md (mmx_andnot3): Remove general register alternative. (*andnot3): Ditto. (*mmx_3): Ditto. (*3): Ditto. gcc/testsuite/ PR target/100701 * gcc.target/i386/pr100701.c: New test. --- gcc/config/i386/i386.md | 4 +-- gcc/config/i386/mmx.md | 60 ++++++++++++++------------------ gcc/testsuite/gcc.target/i386/pr100701.c | 28 +++++++++++++++ 3 files changed, 55 insertions(+), 37 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr100701.c diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 2fc8fae..960ecbd 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -815,7 +815,7 @@ (define_attr "movu" "0,1" (const_string "0")) ;; Used to control the "enabled" attribute on a per-instruction basis. -(define_attr "isa" "base,x64,nox64,x64_bmi,x64_sse2,x64_sse4,x64_sse4_noavx, +(define_attr "isa" "base,x64,nox64,x64_sse2,x64_sse4,x64_sse4_noavx, x64_avx,x64_avx512bw,x64_avx512dq, sse_noavx,sse2,sse2_noavx,sse3,sse3_noavx,sse4,sse4_noavx, avx,noavx,avx2,noavx2,bmi,bmi2,fma4,fma,avx512f,noavx512f, @@ -831,8 +831,6 @@ (define_attr "enabled" "" (cond [(eq_attr "isa" "x64") (symbol_ref "TARGET_64BIT") (eq_attr "isa" "nox64") (symbol_ref "!TARGET_64BIT") - (eq_attr "isa" "x64_bmi") - (symbol_ref "TARGET_64BIT && TARGET_BMI") (eq_attr "isa" "x64_sse2") (symbol_ref "TARGET_64BIT && TARGET_SSE2") (eq_attr "isa" "x64_sse4") diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index 948ba47..baeed04 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -2055,40 +2055,34 @@ "operands[2] = force_reg (mode, CONSTM1_RTX (mode));") (define_insn "mmx_andnot3" - [(set (match_operand:MMXMODEI 0 "register_operand" "=y,r,x,x,v") + [(set (match_operand:MMXMODEI 0 "register_operand" "=y,x,x,v") (and:MMXMODEI - (not:MMXMODEI (match_operand:MMXMODEI 1 "register_operand" - "0,r,0,x,v")) - (match_operand:MMXMODEI 2 "register_mmxmem_operand" - "ym,r,x,x,v")))] + (not:MMXMODEI (match_operand:MMXMODEI 1 "register_operand" "0,0,x,v")) + (match_operand:MMXMODEI 2 "register_mmxmem_operand" "ym,x,x,v")))] "TARGET_MMX || TARGET_MMX_WITH_SSE" "@ pandn\t{%2, %0|%0, %2} - andn\t{%2, %1, %0|%0, %1, %2} pandn\t{%2, %0|%0, %2} vpandn\t{%2, %1, %0|%0, %1, %2} vpandnd\t{%2, %1, %0|%0, %1, %2}" - [(set_attr "isa" "*,x64_bmi,sse2_noavx,avx,avx512vl") - (set_attr "mmx_isa" "native,*,*,*,*") - (set_attr "type" "mmxadd,bitmanip,sselog,sselog,sselog") - (set_attr "btver2_decode" "*,direct,*,*,*") - (set_attr "mode" "DI,DI,TI,TI,TI")]) + [(set_attr "isa" "*,sse2_noavx,avx,avx512vl") + (set_attr "mmx_isa" "native,*,*,*") + (set_attr "type" "mmxadd,sselog,sselog,sselog") + (set_attr "mode" "DI,TI,TI,TI")]) (define_insn "*andnot3" - [(set (match_operand:VI_32 0 "register_operand" "=r,x,x,v") + [(set (match_operand:VI_32 0 "register_operand" "=x,x,v") (and:VI_32 - (not:VI_32 (match_operand:VI_32 1 "register_operand" "r,0,x,v")) - (match_operand:VI_32 2 "register_operand" "r,x,x,v")))] + (not:VI_32 (match_operand:VI_32 1 "register_operand" "0,x,v")) + (match_operand:VI_32 2 "register_operand" "x,x,v")))] "TARGET_SSE2" "@ - andn\t{%2, %1, %0|%0, %1, %2} pandn\t{%2, %0|%0, %2} vpandn\t{%2, %1, %0|%0, %1, %2} vpandnd\t{%2, %1, %0|%0, %1, %2}" - [(set_attr "isa" "bmi,noavx,avx,avx512vl") - (set_attr "type" "bitmanip,sselog,sselog,sselog") - (set_attr "btver2_decode" "direct,*,*,*") - (set_attr "mode" "SI,TI,TI,TI")]) + [(set_attr "isa" "noavx,avx,avx512vl") + (set_attr "type" "sselog") + (set_attr "mode" "TI")]) (define_expand "mmx_3" [(set (match_operand:MMXMODEI 0 "register_operand") @@ -2107,22 +2101,21 @@ "ix86_fixup_binary_operands_no_copy (, mode, operands);") (define_insn "*mmx_3" - [(set (match_operand:MMXMODEI 0 "register_operand" "=y,r,x,x,v") + [(set (match_operand:MMXMODEI 0 "register_operand" "=y,x,x,v") (any_logic:MMXMODEI - (match_operand:MMXMODEI 1 "register_mmxmem_operand" "%0,0,0,x,v") - (match_operand:MMXMODEI 2 "register_mmxmem_operand" "ym,r,x,x,v")))] + (match_operand:MMXMODEI 1 "register_mmxmem_operand" "%0,0,x,v") + (match_operand:MMXMODEI 2 "register_mmxmem_operand" "ym,x,x,v")))] "(TARGET_MMX || TARGET_MMX_WITH_SSE) && ix86_binary_operator_ok (, mode, operands)" "@ p\t{%2, %0|%0, %2} - \t{%2, %0|%0, %2} p\t{%2, %0|%0, %2} vp\t{%2, %1, %0|%0, %1, %2} vpd\t{%2, %1, %0|%0, %1, %2}" - [(set_attr "isa" "*,x64,sse2_noavx,avx,avx512vl") - (set_attr "mmx_isa" "native,*,*,*,*") - (set_attr "type" "mmxadd,alu,sselog,sselog,sselog") - (set_attr "mode" "DI,DI,TI,TI,TI")]) + [(set_attr "isa" "*,sse2_noavx,avx,avx512vl") + (set_attr "mmx_isa" "native,*,*,*") + (set_attr "type" "mmxadd,sselog,sselog,sselog") + (set_attr "mode" "DI,TI,TI,TI")]) (define_expand "3" [(set (match_operand:VI_32 0 "register_operand") @@ -2133,20 +2126,19 @@ "ix86_fixup_binary_operands_no_copy (, mode, operands);") (define_insn "*3" - [(set (match_operand:VI_32 0 "register_operand" "=r,x,x,v") + [(set (match_operand:VI_32 0 "register_operand" "=x,x,v") (any_logic:VI_32 - (match_operand:VI_32 1 "register_operand" "%0,0,x,v") - (match_operand:VI_32 2 "register_operand" "r,x,x,v")))] + (match_operand:VI_32 1 "register_operand" "%0,x,v") + (match_operand:VI_32 2 "register_operand" "x,x,v")))] "TARGET_SSE2 && ix86_binary_operator_ok (, mode, operands)" "@ - \t{%2, %0|%0, %2} p\t{%2, %0|%0, %2} vp\t{%2, %1, %0|%0, %1, %2} vpd\t{%2, %1, %0|%0, %1, %2}" - [(set_attr "isa" "*,noavx,avx,avx512vl") - (set_attr "type" "alu,sselog,sselog,sselog") - (set_attr "mode" "SI,TI,TI,TI")]) + [(set_attr "isa" "noavx,avx,avx512vl") + (set_attr "type" "sselog") + (set_attr "mode" "TI")]) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; diff --git a/gcc/testsuite/gcc.target/i386/pr100701.c b/gcc/testsuite/gcc.target/i386/pr100701.c new file mode 100644 index 0000000..3132d66 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr100701.c @@ -0,0 +1,28 @@ +/* PR target/100701 */ +/* { dg-do run { target { ! ia32 } } } */ +/* { dg-options "-O0 -fschedule-insns2 -msse2" } */ + +typedef unsigned char __attribute__((__vector_size__ (8))) V; +typedef unsigned int __attribute__((__vector_size__ (8))) U; + +U u; +unsigned x; +unsigned char y; + +V +foo (V a, __int128 i) +{ + V b = a; + a &= y; + if (i == 0) + __builtin_abort (); + U c = (x != y / i) <= u; + return (V) c + a + b; +} + +int +main (void) +{ + (void)foo ((V) { }, 4); + return 0; +} -- 2.7.4