From a6d76cf6101d0479af2d9c9266427c0ea51e3889 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sat, 27 Feb 2021 18:32:21 +0000 Subject: [PATCH] Change the error message when `-split-input-file` is used with mlir-opt to make it recognizable by IDEs By adding the line number of the split point immediately after the file name (separated by `:`) this is recognized by various tool as a proper location. Ideally we would want to point to the line of the error, but that would require some very invasive changes I suspect. Reviewed By: jpienaar Differential Revision: https://reviews.llvm.org/D93363 --- mlir/lib/Support/ToolUtilities.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mlir/lib/Support/ToolUtilities.cpp b/mlir/lib/Support/ToolUtilities.cpp index 26a8b08..ef1a4111 100644 --- a/mlir/lib/Support/ToolUtilities.cpp +++ b/mlir/lib/Support/ToolUtilities.cpp @@ -37,8 +37,9 @@ mlir::splitAndProcessBuffer(std::unique_ptr originalBuffer, auto splitLoc = llvm::SMLoc::getFromPointer(subBuffer.data()); unsigned splitLine = fileSourceMgr.getLineAndColumn(splitLoc).first; auto subMemBuffer = llvm::MemoryBuffer::getMemBufferCopy( - subBuffer, origMemBuffer->getBufferIdentifier() + - Twine(" split at line #") + Twine(splitLine)); + subBuffer, Twine("within split at ") + + origMemBuffer->getBufferIdentifier() + ":" + + Twine(splitLine) + " offset "); if (failed(processChunkBuffer(std::move(subMemBuffer), os))) hadFailure = true; } -- 2.7.4