From a6bb63dcd714cd580f5296f39c008fe090820745 Mon Sep 17 00:00:00 2001 From: Nirbheek Chauhan Date: Mon, 14 Mar 2022 13:45:36 +0530 Subject: [PATCH] twcc: Note that packet-loss-pct can count reordering as loss This is difficult to encounter in ordinary networks, but is encountered when using tc-netem to add random delays to packets, and also when your UDP stream is bonded over multiple links with varying characteristics. Part-of: --- subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c index 424e933..cc9d59f 100644 --- a/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c +++ b/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c @@ -774,7 +774,11 @@ gst_rtp_session_class_init (GstRtpSessionClass * klass) * "packets-sent" G_TYPE_UINT Number of packets sent * "packets-recv" G_TYPE_UINT Number of packets reported recevied * "packet-loss-pct" G_TYPE_DOUBLE Packetloss percentage, based on - * packets reported as lost from the recevier. + * packets reported as lost from the receiver. Note: depending on the + * implementation of the receiver and due to the nature of the TWCC + * RRs being sent with high frequency, out of order packets may not + * be fully accounted for and this number could be higher than other + * measurement sources of packet loss. * "avg-delta-of-delta", G_TYPE_INT64 In nanoseconds, a moving window * average of the difference in inter-packet spacing between * sender and receiver. A sudden increase in this number can indicate -- 2.7.4