From a6b0219fc4a78e96ff268d101b911466dedbbf2c Mon Sep 17 00:00:00 2001 From: Jian Cai Date: Fri, 25 Oct 2019 14:03:07 -0700 Subject: [PATCH] Revert "[ARM] Uses "Sun Style" syntax for section switching" This reverts commit 03de2f84fc4acf06c719cd007b5459c9d4d0a20c. --- llvm/include/llvm/MC/MCAsmInfo.h | 2 +- llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp | 4 ---- llvm/test/MC/AsmParser/gas-compl-sun-elf.s | 13 ------------- 3 files changed, 1 insertion(+), 18 deletions(-) delete mode 100644 llvm/test/MC/AsmParser/gas-compl-sun-elf.s diff --git a/llvm/include/llvm/MC/MCAsmInfo.h b/llvm/include/llvm/MC/MCAsmInfo.h index ce24ffb..3261c48 100644 --- a/llvm/include/llvm/MC/MCAsmInfo.h +++ b/llvm/include/llvm/MC/MCAsmInfo.h @@ -215,7 +215,7 @@ protected: const char *TPRel64Directive = nullptr; /// This is true if this target uses "Sun Style" syntax for section switching - /// ("#alloc,#write" etc) alongside the normal ELF syntax (,"a,w") in + /// ("#alloc,#write" etc) instead of the normal ELF syntax (,"a,w") in /// .section directives. Defaults to false. bool SunStyleELFSectionSwitchSyntax = false; diff --git a/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp b/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp index 03505c0..d30d15d 100644 --- a/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp +++ b/llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp @@ -75,10 +75,6 @@ ARMELFMCAsmInfo::ARMELFMCAsmInfo(const Triple &TheTriple) { UseParensForSymbolVariant = true; UseIntegratedAssembler = true; - - // The GNU assembler supports Sun style section switching for Arm targets, and - // it is used in projects like the Linux kernel. - SunStyleELFSectionSwitchSyntax = true; } void ARMELFMCAsmInfo::setUseIntegratedAssembler(bool Value) { diff --git a/llvm/test/MC/AsmParser/gas-compl-sun-elf.s b/llvm/test/MC/AsmParser/gas-compl-sun-elf.s deleted file mode 100644 index 7934109..0000000 --- a/llvm/test/MC/AsmParser/gas-compl-sun-elf.s +++ /dev/null @@ -1,13 +0,0 @@ -@ RUN: llvm-mc -filetype=obj -triple arm-linux-gnu %s -o - | llvm-readelf --sections | FileCheck %s - -@ CHECK: .f1 PROGBITS 00000000 000034 000000 00 A 0 0 1 -.section ".f1", #alloc - -@ CHECK: .f2 PROGBITS 00000000 000034 000000 00 W 0 0 1 -.section ".f2", #write - -@ CHECK: .f3 PROGBITS 00000000 000034 000000 00 A 0 0 1 -.section ".f3", "a" - -@ CHECK: .f4 PROGBITS 00000000 000034 000000 00 W 0 0 1 -.section ".f4", "w" -- 2.7.4