From a661827ab4e2c3290d9b18c2174130d7af416d08 Mon Sep 17 00:00:00 2001 From: Slawomir Pajak Date: Fri, 11 Oct 2013 11:19:49 +0200 Subject: [PATCH] Warning fix [Issue#] LINUXWRT-1003 [Problem] Warning during building wrt-commons in property_dao_read_only.cpp file [Cause] Function visible outside and not declared in header file [Solution] Function moved to anonymous namespace because it's used only internally. [Verification] Observe no warning during building property_dao_read_only.cpp Change-Id: I9587eaf123a4779b3b13383ad658009075027589 --- .../widget_dao/dao/property_dao_read_only.cpp | 35 +++++++++---------- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/modules/widget_dao/dao/property_dao_read_only.cpp b/modules/widget_dao/dao/property_dao_read_only.cpp index 3676d5a..fac99a8 100644 --- a/modules/widget_dao/dao/property_dao_read_only.cpp +++ b/modules/widget_dao/dao/property_dao_read_only.cpp @@ -74,6 +74,23 @@ void convertWidgetPropertyKeyList(const ORMWidgetPropertyKeyList& propKeyList, keyList.push_back(*it); } } + +WidgetPreferenceList GetPropertyListRows(DbWidgetHandle widgetHandle) +{ + Try { + using namespace DPL::DB::ORM; + using namespace DPL::DB::ORM::wrt; + WRT_DB_SELECT(select, WidgetPreference, &WrtDatabase::interface()) + select->Where(Equals(widgetHandle)); + ORMWidgetPreferenceList ormPrefList = select->GetRowList(); + WidgetPreferenceList prefList; + convertWidgetPreferenceRow(ormPrefList, prefList); + return prefList; + }Catch(DPL::DB::SqlConnection::Exception::Base){ + ReThrowMsg(Exception::DatabaseError, + "Failure during getting property list"); + } +} } //deprecated @@ -133,24 +150,6 @@ WidgetPropertyKeyList GetPropertyKeyList(TizenAppId tzAppid) } } - -WidgetPreferenceList GetPropertyListRows(DbWidgetHandle widgetHandle) -{ - Try { - using namespace DPL::DB::ORM; - using namespace DPL::DB::ORM::wrt; - WRT_DB_SELECT(select, WidgetPreference, &WrtDatabase::interface()) - select->Where(Equals(widgetHandle)); - ORMWidgetPreferenceList ormPrefList = select->GetRowList(); - WidgetPreferenceList prefList; - convertWidgetPreferenceRow(ormPrefList, prefList); - return prefList; - }Catch(DPL::DB::SqlConnection::Exception::Base){ - ReThrowMsg(Exception::DatabaseError, - "Failure during getting property list"); - } -} - WidgetPreferenceList GetPropertyList(DbWidgetHandle widgetHandle) { if(!(WidgetDAOReadOnly::isWidgetInstalled(widgetHandle))) -- 2.34.1