From a6452ae2f1475a62458fbaab51d6afb5a7de514f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Victor=20Garc=C3=ADa?= Date: Fri, 22 Feb 2013 17:21:05 +0100 Subject: [PATCH] mutable objects mustn't be initialized in method params --- jenkinsapi/job.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jenkinsapi/job.py b/jenkinsapi/job.py index 1124b7e..5fef16e 100644 --- a/jenkinsapi/job.py +++ b/jenkinsapi/job.py @@ -64,7 +64,7 @@ class Job(JenkinsBase): self._element_tree = ET.fromstring(self._config) return self._element_tree - def get_build_triggerurl( self, token=None, params={} ): + def get_build_triggerurl(self, token=None, params=None): if token is None and not params: extra = "build" elif params: @@ -78,7 +78,7 @@ class Job(JenkinsBase): buildurl = urlparse.urljoin( self.baseurl, extra ) return buildurl - def invoke(self, securitytoken=None, block=False, skip_if_running=False, invoke_pre_check_delay=3, invoke_block_delay=15, params={}): + def invoke(self, securitytoken=None, block=False, skip_if_running=False, invoke_pre_check_delay=3, invoke_block_delay=15, params=None): assert isinstance( invoke_pre_check_delay, (int, float) ) assert isinstance( invoke_block_delay, (int, float) ) assert isinstance( block, bool ) @@ -94,7 +94,7 @@ class Job(JenkinsBase): log.warn("Will re-schedule %s even though it is already running" % self.id() ) original_build_no = self.get_last_buildnumber() log.info( "Attempting to start %s on %s" % ( self.id(), repr(self.get_jenkins_obj()) ) ) - url = self.get_build_triggerurl( securitytoken, params) + url = self.get_build_triggerurl(securitytoken, params) html_result = self.hit_url(url) assert len( html_result ) > 0 if invoke_pre_check_delay > 0: -- 2.34.1