From a5f5288a1ce96404c41043e92557b8c1a5ad9e30 Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Fri, 12 May 2006 14:08:45 +0000 Subject: [PATCH] The upgrade/croak order in Perl_sv_utf8_encode() seemed utterly backwards. It now checks for readonly *first*. p4raw-id: //depot/perl@28178 --- sv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sv.c b/sv.c index b014601b92..6c7071dd18 100644 --- a/sv.c +++ b/sv.c @@ -3100,13 +3100,13 @@ flag off so that it looks like octets again. void Perl_sv_utf8_encode(pTHX_ register SV *sv) { - (void) sv_utf8_upgrade(sv); if (SvIsCOW(sv)) { sv_force_normal_flags(sv, 0); } if (SvREADONLY(sv)) { Perl_croak(aTHX_ PL_no_modify); } + (void) sv_utf8_upgrade(sv); SvUTF8_off(sv); } -- 2.34.1