From a5f3ccc0376d385de6cf6ab79308f7d346a3d55a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fran=C3=A7ois=20Laignel?= Date: Fri, 21 Oct 2022 11:47:11 +0200 Subject: [PATCH 1/1] gst: uri query: fix inconsistent `uri` nullability assertion Functions `gst_query_set_uri` and `gst_query_set_uri_redirection` can both set a `NULL` `uri`, as annotated in the documentation. However the functions bodies reject `NULL` `uri`s. See [1] for a discussion on that matter. [1]: https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1134#note_1600988 Part-of: --- subprojects/gstreamer/gst/gstquery.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/subprojects/gstreamer/gst/gstquery.c b/subprojects/gstreamer/gst/gstquery.c index 9d339d0..1c6da5d 100644 --- a/subprojects/gstreamer/gst/gstquery.c +++ b/subprojects/gstreamer/gst/gstquery.c @@ -1399,7 +1399,6 @@ gst_query_set_uri (GstQuery * query, const gchar * uri) g_return_if_fail (GST_QUERY_TYPE (query) == GST_QUERY_URI); g_return_if_fail (gst_query_is_writable (query)); - g_return_if_fail (gst_uri_is_valid (uri)); structure = GST_QUERY_STRUCTURE (query); gst_structure_id_set (structure, GST_QUARK (URI), G_TYPE_STRING, uri, NULL); @@ -1444,7 +1443,6 @@ gst_query_set_uri_redirection (GstQuery * query, const gchar * uri) g_return_if_fail (GST_QUERY_TYPE (query) == GST_QUERY_URI); g_return_if_fail (gst_query_is_writable (query)); - g_return_if_fail (gst_uri_is_valid (uri)); structure = GST_QUERY_STRUCTURE (query); gst_structure_id_set (structure, GST_QUARK (URI_REDIRECTION), -- 2.7.4