From a5901d45b8b715ddb3315b46b057c7c87675c66e Mon Sep 17 00:00:00 2001 From: "k2.nagaraju" Date: Fri, 28 Sep 2018 21:44:00 +0530 Subject: [PATCH] get widget.width and widget.height from widget_info widget.width and widget.height values should be get from widget_info object not from window.innerWidth and window.innerHeight. Change-Id: I7c1974653b0166ea331177bc3d545025877365c6 Signed-off-by: k2.nagaraju --- extensions/internal/widget/widget_api.js | 12 ++++-------- extensions/renderer/widget_module.cc | 6 ++++++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/extensions/internal/widget/widget_api.js b/extensions/internal/widget/widget_api.js index 6a5b7a6..fe680f1 100755 --- a/extensions/internal/widget/widget_api.js +++ b/extensions/internal/widget/widget_api.js @@ -67,16 +67,12 @@ function Widget() { writable: false }, "height": { - get: function() { - return window && window.innerHeight || 0; - }, - configurable: false + value: widget_info_["height"], + writable: false }, "width": { - get: function() { - return window && window.innerWidth || 0; - }, - configurable: false + value: widget_info_["width"], + writable: false }, "preferences": { value: preference_, diff --git a/extensions/renderer/widget_module.cc b/extensions/renderer/widget_module.cc index 2237501..4f5b803 100644 --- a/extensions/renderer/widget_module.cc +++ b/extensions/renderer/widget_module.cc @@ -348,6 +348,12 @@ v8::Handle WidgetModule::NewInstance() { widget->Set( v8::String::NewFromUtf8(isolate, "authorHref"), v8::String::NewFromUtf8(isolate, widgetdb->authorHref().c_str())); + widget->Set( + v8::String::NewFromUtf8(isolate, "width"), + v8::Uint32::NewFromUnsigned(isolate, widgetdb->width())); + widget->Set( + v8::String::NewFromUtf8(isolate, "height"), + v8::Uint32::NewFromUnsigned(isolate, widgetdb->height())); return handle_scope.Escape(widget); } -- 2.7.4