From a577659f42f745b71cbc56c80fb1e801ec7e6348 Mon Sep 17 00:00:00 2001 From: Sachin Kamat Date: Mon, 2 Sep 2013 13:54:20 +0530 Subject: [PATCH] dma: mv_xor: Fix incorrect error path Return directly if memory allocation fails. There is no need of dma_free_coherent(). Signed-off-by: Sachin Kamat Cc: Saeed Bishara Signed-off-by: Dan Williams --- drivers/dma/mv_xor.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index d332b9e..0ec086d 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1036,10 +1036,8 @@ mv_xor_channel_add(struct mv_xor_device *xordev, struct dma_device *dma_dev; mv_chan = devm_kzalloc(&pdev->dev, sizeof(*mv_chan), GFP_KERNEL); - if (!mv_chan) { - ret = -ENOMEM; - goto err_free_dma; - } + if (!mv_chan) + return ERR_PTR(-ENOMEM); mv_chan->idx = idx; mv_chan->irq = irq; -- 2.7.4