From a5744ae8e2e166ebd2a152aeed4c0cec59ec6b9f Mon Sep 17 00:00:00 2001 From: Samantha Houts Date: Fri, 10 May 2019 13:38:39 -0700 Subject: [PATCH] [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText... (#6165) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit * [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText But more concerning is that the `shellIconTextDescription` isn't used at all. Is it leftover code, or is this a mistake? * [Android] Remove dead code from shellIconTextDescripion --- Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs b/Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs index 231da55..49ad8d6 100644 --- a/Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs +++ b/Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs @@ -292,8 +292,6 @@ namespace Xamarin.Forms.Platform.Android protected virtual void UpdateToolbarIconAccessibilityText(Toolbar toolbar, Shell shell) { - var shellIconTextDescription = shell.FlyoutIcon?.AutomationId ?? AutomationProperties.GetHelpText(_shellContext.Shell.FlyoutIcon) ?? shell.AutomationId; - //if AutomationId was specified the user wants to use UITests and interact with FlyoutIcon if (!string.IsNullOrEmpty(shell.FlyoutIcon?.AutomationId)) { -- 2.7.4