From a56c917009ad16b74f98fa3e453b30332a264efb Mon Sep 17 00:00:00 2001 From: "jochen@chromium.org" Date: Wed, 30 Jul 2014 11:41:48 +0000 Subject: [PATCH] Drop deprecated memory related notification API Embedders should use the non-static methods on Isolate with the same name. BUG=397026 R=hpayer@chromium.org LOG=y Review URL: https://codereview.chromium.org/429593003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- include/v8.h | 34 ---------------------------------- src/api.cc | 28 ---------------------------- 2 files changed, 62 deletions(-) diff --git a/include/v8.h b/include/v8.h index 8cfeacd..c1e714a 100644 --- a/include/v8.h +++ b/include/v8.h @@ -4994,40 +4994,6 @@ class V8_EXPORT V8 { Isolate* isolate, PersistentHandleVisitor* visitor); /** - * Optional notification that the embedder is idle. - * V8 uses the notification to reduce memory footprint. - * This call can be used repeatedly if the embedder remains idle. - * Returns true if the embedder should stop calling IdleNotification - * until real work has been done. This indicates that V8 has done - * as much cleanup as it will be able to do. - * - * The hint argument specifies the amount of work to be done in the function - * on scale from 1 to 1000. There is no guarantee that the actual work will - * match the hint. - * - * Deprecated, please use Isolate::IdleNotification. - */ - static bool IdleNotification(int hint = 1000); - - /** - * Optional notification that the system is running low on memory. - * V8 uses these notifications to attempt to free memory. - * - * Deprecated, please use Isolate::LowMemoryNotification. - */ - static void LowMemoryNotification(); - - /** - * Optional notification that a context has been disposed. V8 uses - * these notifications to guide the GC heuristic. Returns the number - * of context disposals - including this one - since the last time - * V8 had a chance to clean up. - * - * Deprecated, please use Isolate::ContextDisposedNotification. - */ - static int ContextDisposedNotification(); - - /** * Initialize the ICU library bundled with V8. The embedder should only * invoke this method when using the bundled ICU. Returns true on success. * diff --git a/src/api.cc b/src/api.cc index e473540..47ad191 100644 --- a/src/api.cc +++ b/src/api.cc @@ -5078,34 +5078,6 @@ void v8::V8::VisitHandlesForPartialDependence( } -bool v8::V8::IdleNotification(int hint) { - // Returning true tells the caller that it need not - // continue to call IdleNotification. - i::Isolate* isolate = i::Isolate::Current(); - if (isolate == NULL || !isolate->IsInitialized()) return true; - if (!i::FLAG_use_idle_notification) return true; - return isolate->heap()->IdleNotification(hint); -} - - -void v8::V8::LowMemoryNotification() { - i::Isolate* isolate = i::Isolate::Current(); - if (isolate == NULL || !isolate->IsInitialized()) return; - { - i::HistogramTimerScope idle_notification_scope( - isolate->counters()->gc_low_memory_notification()); - isolate->heap()->CollectAllAvailableGarbage("low memory notification"); - } -} - - -int v8::V8::ContextDisposedNotification() { - i::Isolate* isolate = i::Isolate::Current(); - if (!isolate->IsInitialized()) return 0; - return isolate->heap()->NotifyContextDisposed(); -} - - bool v8::V8::InitializeICU(const char* icu_data_file) { return i::InitializeICU(icu_data_file); } -- 2.7.4