From a525a76e54f602b1d05a1f6f889d71abbc7a8d1a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 16 Dec 2021 18:41:38 +0000 Subject: [PATCH] opusenc: change default bitrate-type from cbr to constrained-vbr Which is the default in libopus itself as well, with a comment that constrained-vbr is considered "safer for real-time use". Unclear why CBR was the default in the first place. Part-of: --- subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json | 2 +- subprojects/gst-plugins-base/ext/opus/gstopusenc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json index e02131d..650f5d2 100644 --- a/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json @@ -7769,7 +7769,7 @@ "construct": false, "construct-only": false, "controllable": false, - "default": "cbr (0)", + "default": "constrained-vbr (2)", "mutable": "playing", "readable": true, "type": "GstOpusEncBitrateType", diff --git a/subprojects/gst-plugins-base/ext/opus/gstopusenc.c b/subprojects/gst-plugins-base/ext/opus/gstopusenc.c index f406d86..805ccd7 100644 --- a/subprojects/gst-plugins-base/ext/opus/gstopusenc.c +++ b/subprojects/gst-plugins-base/ext/opus/gstopusenc.c @@ -195,7 +195,7 @@ static GstStaticPadTemplate src_factory = GST_STATIC_PAD_TEMPLATE ("src", #define DEFAULT_FRAMESIZE 20 #define DEFAULT_CBR TRUE #define DEFAULT_CONSTRAINED_VBR TRUE -#define DEFAULT_BITRATE_TYPE BITRATE_TYPE_CBR +#define DEFAULT_BITRATE_TYPE BITRATE_TYPE_CONSTRAINED_VBR #define DEFAULT_COMPLEXITY 10 #define DEFAULT_INBAND_FEC FALSE #define DEFAULT_DTX FALSE -- 2.7.4