From a5113fe8c88dcb45bb871b6c6ec85233fd0b1ce7 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Sat, 17 Feb 2018 19:38:22 -0500 Subject: [PATCH] vc1parser: Relax ASF Binding Byte validation According to the spec, the least significant bit is reserved and should always we set to 1. Though, some wrong file has been found. Considering how low important this reserved bit is, relax the validation. Related to #660 --- gst/videoparsers/gstvc1parse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gst/videoparsers/gstvc1parse.c b/gst/videoparsers/gstvc1parse.c index df54a241ff..d80f9bba2c 100644 --- a/gst/videoparsers/gstvc1parse.c +++ b/gst/videoparsers/gstvc1parse.c @@ -2423,10 +2423,10 @@ gst_vc1_parse_set_caps (GstBaseParse * parse, GstCaps * caps) /* Some sanity checking */ if ((minfo.data[0] & 0x01) != 0x01) { - GST_ERROR_OBJECT (vc1parse, + GST_WARNING_OBJECT (vc1parse, "Invalid binding byte for VC1 advanced profile ASF header"); - gst_buffer_unmap (codec_data, &minfo); - return FALSE; + /* stay relax on the validation, it's quite minor to set the reserved + * bit to 0 instead of 1, also see bug #793551 */ } start_code = GST_READ_UINT32_BE (minfo.data + 1); -- 2.34.1