From a4957224a80d7dbfbeca8e15052fb02e9d9123c1 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= <tim@centricular.net>
Date: Tue, 7 Mar 2006 11:47:24 +0000
Subject: [PATCH] gst/gstvalue.c: Document thread-unsafety of
 gst_value_register_foo_func() when used at the same time as gst_value_foo...

Original commit message from CVS:
* gst/gstvalue.c:
Document thread-unsafety of gst_value_register_foo_func()
when used at the same time as gst_value_foo() (#322628).
---
 ChangeLog      |  6 ++++++
 gst/gstvalue.c | 12 ++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index eb4895c..22fa663 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2006-03-07  Tim-Philipp Müller  <tim at centricular dot net>
 
+	* gst/gstvalue.c:
+	  Document thread-unsafety of gst_value_register_foo_func()
+	  when used at the same time as gst_value_foo() (#322628).
+
+2006-03-07  Tim-Philipp Müller  <tim at centricular dot net>
+
 	* libs/gst/base/gstpushsrc.c: (gst_push_src_class_init),
 	(gst_push_src_check_get_range):
 	  Push sources don't support pull mode by default.
diff --git a/gst/gstvalue.c b/gst/gstvalue.c
index 39af6fe..d8b37f7 100644
--- a/gst/gstvalue.c
+++ b/gst/gstvalue.c
@@ -2713,6 +2713,9 @@ gst_value_union (GValue * dest, const GValue * value1, const GValue * value2)
  * Registers a union function that can create a union between GValues
  * of the type @type1 and @type2.
  *
+ * Union functions should be registered at startup before any pipelines are
+ * started, as gst_value_register_union_func() is not thread-safe and cannot
+ * be used at the same time as gst_value_union() or gst_value_can_union().
  */
 void
 gst_value_register_union_func (GType type1, GType type2, GstValueUnionFunc func)
@@ -2822,6 +2825,11 @@ gst_value_intersect (GValue * dest, const GValue * value1,
  *
  * Registers a function that is called to calculate the intersection
  * of the values having the types @type1 and @type2.
+ *
+ * Intersect functions should be registered at startup before any pipelines are
+ * started, as gst_value_register_intersect_func() is not thread-safe and
+ * cannot be used at the same time as gst_value_intersect() or
+ * gst_value_can_intersect().
  */
 void
 gst_value_register_intersect_func (GType type1, GType type2,
@@ -2930,6 +2938,10 @@ gst_value_can_subtract (const GValue * minuend, const GValue * subtrahend)
  *
  * Registers @func as a function capable of subtracting the values of
  * @subtrahend_type from values of @minuend_type.
+ *
+ * Subtract functions should be registered at startup before any pipelines are
+ * started, as gst_value_register_subtract_func() is not thread-safe and
+ * cannot be used at the same time as gst_value_subtract().
  */
 void
 gst_value_register_subtract_func (GType minuend_type, GType subtrahend_type,
-- 
2.7.4