From a4605ef9b0b36155a2b0c94a3b218c49c594c419 Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Fri, 11 Sep 2015 09:00:44 -0700 Subject: [PATCH] [MIPS] Remove obsolete MacroAssembler::FlushICache. R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1334273002 Cr-Commit-Position: refs/heads/master@{#30701} --- src/assembler.cc | 6 ------ src/assembler.h | 1 - src/mips/macro-assembler-mips.cc | 14 -------------- src/mips/macro-assembler-mips.h | 5 ----- src/mips64/macro-assembler-mips64.cc | 14 -------------- src/mips64/macro-assembler-mips64.h | 5 ----- src/snapshot/serialize.cc | 2 -- 7 files changed, 47 deletions(-) diff --git a/src/assembler.cc b/src/assembler.cc index e2e102489..49b300eb2 100644 --- a/src/assembler.cc +++ b/src/assembler.cc @@ -1048,12 +1048,6 @@ ExternalReference ExternalReference:: } -ExternalReference ExternalReference::flush_icache_function(Isolate* isolate) { - return ExternalReference( - Redirect(isolate, FUNCTION_ADDR(Assembler::FlushICacheWithoutIsolate))); -} - - ExternalReference ExternalReference::delete_handle_scope_extensions( Isolate* isolate) { return ExternalReference(Redirect( diff --git a/src/assembler.h b/src/assembler.h index 9bfda3649..10e9bb4e0 100644 --- a/src/assembler.h +++ b/src/assembler.h @@ -896,7 +896,6 @@ class ExternalReference BASE_EMBEDDED { Isolate* isolate); static ExternalReference store_buffer_overflow_function( Isolate* isolate); - static ExternalReference flush_icache_function(Isolate* isolate); static ExternalReference delete_handle_scope_extensions(Isolate* isolate); static ExternalReference get_date_field_function(Isolate* isolate); diff --git a/src/mips/macro-assembler-mips.cc b/src/mips/macro-assembler-mips.cc index 961e9d595..8e3bc03d3 100644 --- a/src/mips/macro-assembler-mips.cc +++ b/src/mips/macro-assembler-mips.cc @@ -1220,20 +1220,6 @@ void MacroAssembler::MultiPopReversedFPU(RegList regs) { } -void MacroAssembler::FlushICache(Register address, unsigned instructions) { - RegList saved_regs = kJSCallerSaved | ra.bit(); - MultiPush(saved_regs); - AllowExternalCallThatCantCauseGC scope(this); - - Move(a0, address); - PrepareCallCFunction(2, t8); - - li(a1, instructions * kInstrSize); - CallCFunction(ExternalReference::flush_icache_function(isolate()), 2); - MultiPop(saved_regs); -} - - void MacroAssembler::Ext(Register rt, Register rs, uint16_t pos, diff --git a/src/mips/macro-assembler-mips.h b/src/mips/macro-assembler-mips.h index 96eb9b410..4b7e37b80 100644 --- a/src/mips/macro-assembler-mips.h +++ b/src/mips/macro-assembler-mips.h @@ -768,11 +768,6 @@ class MacroAssembler: public Assembler { // into register dst. void LoadFromSafepointRegisterSlot(Register dst, Register src); - // Flush the I-cache from asm code. You should use CpuFeatures::FlushICache - // from C. - // Does not handle errors. - void FlushICache(Register address, unsigned instructions); - // MIPS32 R2 instruction macro. void Ins(Register rt, Register rs, uint16_t pos, uint16_t size); void Ext(Register rt, Register rs, uint16_t pos, uint16_t size); diff --git a/src/mips64/macro-assembler-mips64.cc b/src/mips64/macro-assembler-mips64.cc index 0aa678527..8ab459709 100644 --- a/src/mips64/macro-assembler-mips64.cc +++ b/src/mips64/macro-assembler-mips64.cc @@ -1434,20 +1434,6 @@ void MacroAssembler::MultiPopReversedFPU(RegList regs) { } -void MacroAssembler::FlushICache(Register address, unsigned instructions) { - RegList saved_regs = kJSCallerSaved | ra.bit(); - MultiPush(saved_regs); - AllowExternalCallThatCantCauseGC scope(this); - - Move(a0, address); - PrepareCallCFunction(2, t8); - - li(a1, instructions * kInstrSize); - CallCFunction(ExternalReference::flush_icache_function(isolate()), 2); - MultiPop(saved_regs); -} - - void MacroAssembler::Ext(Register rt, Register rs, uint16_t pos, diff --git a/src/mips64/macro-assembler-mips64.h b/src/mips64/macro-assembler-mips64.h index b374d43b7..f69a68f59 100644 --- a/src/mips64/macro-assembler-mips64.h +++ b/src/mips64/macro-assembler-mips64.h @@ -796,11 +796,6 @@ class MacroAssembler: public Assembler { // into register dst. void LoadFromSafepointRegisterSlot(Register dst, Register src); - // Flush the I-cache from asm code. You should use CpuFeatures::FlushICache - // from C. - // Does not handle errors. - void FlushICache(Register address, unsigned instructions); - // MIPS64 R2 instruction macro. void Ins(Register rt, Register rs, uint16_t pos, uint16_t size); void Ext(Register rt, Register rs, uint16_t pos, uint16_t size); diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc index 48669955e..4b3284e6b 100644 --- a/src/snapshot/serialize.cc +++ b/src/snapshot/serialize.cc @@ -121,8 +121,6 @@ ExternalReferenceTable::ExternalReferenceTable(Isolate* isolate) { "InvokeFunctionCallback"); Add(ExternalReference::invoke_accessor_getter_callback(isolate).address(), "InvokeAccessorGetterCallback"); - Add(ExternalReference::flush_icache_function(isolate).address(), - "Assembler::FlushICacheWithoutIsolate"); Add(ExternalReference::log_enter_external_function(isolate).address(), "Logger::EnterExternal"); Add(ExternalReference::log_leave_external_function(isolate).address(), -- 2.34.1