From a44fd3014d65f42c5b8dbae62a90e50419cb6d57 Mon Sep 17 00:00:00 2001 From: Daniel Jasper Date: Fri, 16 Dec 2016 13:53:46 +0000 Subject: [PATCH] Move VerifierSupport into namespace llvm. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It currently is in an unnamed namespace and then it shouldn't be used from something in the header file. This actually triggers a warning with GCC: ../include/llvm/IR/Verifier.h:39:7: warning: ‘llvm::TBAAVerifier’ has a field ‘llvm::TBAAVerifier::Diagnostic’ whose type uses the anonymous namespace [enabled by default] llvm-svn: 289942 --- llvm/include/llvm/IR/Verifier.h | 5 +---- llvm/lib/IR/Verifier.cpp | 6 +++++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/llvm/include/llvm/IR/Verifier.h b/llvm/include/llvm/IR/Verifier.h index e5a98d8..be983e4 100644 --- a/llvm/include/llvm/IR/Verifier.h +++ b/llvm/include/llvm/IR/Verifier.h @@ -23,10 +23,6 @@ #include "llvm/IR/PassManager.h" -namespace { -struct VerifierSupport; -} - namespace llvm { class Function; @@ -34,6 +30,7 @@ class FunctionPass; class ModulePass; class Module; class raw_ostream; +struct VerifierSupport; /// Verify that the TBAA Metadatas are valid. class TBAAVerifier { diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp index 7b2b1c4..2b9dfce 100644 --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -117,7 +117,7 @@ using namespace llvm; static cl::opt VerifyDebugInfo("verify-debug-info", cl::init(true)); -namespace { +namespace llvm { struct VerifierSupport { raw_ostream *OS; @@ -248,6 +248,10 @@ public: } }; +} // namespace llvm + +namespace { + class Verifier : public InstVisitor, VerifierSupport { friend class InstVisitor; -- 2.7.4