From a401dcc72dd208d597dbe7434df3af7a2ef929f1 Mon Sep 17 00:00:00 2001 From: Paul Lawrence Date: Wed, 11 Sep 2024 12:53:39 -0700 Subject: [PATCH] ANDROID: dm-bow: Fix empty else blocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit drivers/md/dm-bow.c:1149:51: error: suggest braces around empty body in an ‘else’ statement [-Werror=empty-body] drivers/md/dm-bow.c:1142:51: error: suggest braces around empty body in an ‘else’ statement [-Werror=empty-body] Link to kernelci result: https://linux.kernelci.org/build/android/branch/android-mainline/kernel/v6.11-rc6-6389-g1cf1608b4abd8/ Build log: https://storage.kernelci.org/android/android-mainline/v6.11-rc6-6389-g1cf1608b4abd8/x86_64/allmodconfig/gcc-12/logs/kernel.log Bug: 366029436 Test: compiles Signed-off-by: Paul Lawrence [jh80.chung: Taken from Android Common Kernel repo] Signed-off-by: Jaehoon Chung Change-Id: Ib6ea01a36c0300aba512a743e658737afcc9ebfa --- kernel/dm-bow.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/dm-bow.c b/kernel/dm-bow.c index f8ccfad..3d577a3 100644 --- a/kernel/dm-bow.c +++ b/kernel/dm-bow.c @@ -1138,18 +1138,15 @@ static int dm_bow_map(struct dm_target *ti, struct bio *bio) ret = add_trim(bc, bio); else if (bio_data_dir(bio) == WRITE) ret = remove_trim(bc, bio); - else - /* pass-through */; + /* else pass-through */ } else if (state == CHECKPOINT) { if (bio->bi_iter.bi_sector == 0) ret = handle_sector0(bc, bio); else if (bio_data_dir(bio) == WRITE) ret = queue_write(bc, bio); - else - /* pass-through */; - } else { - /* pass-through */ + /* else pass-through */ } + /* else pass-through */ mutex_unlock(&bc->ranges_lock); } -- 2.34.1