From a3b352c99d2ced8d9622072a4fdde9409434c48f Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Tue, 29 Nov 2022 02:22:50 +0900 Subject: [PATCH] mfvideosrc: Fix buffer leak The allocated buffer should be released Part-of: --- subprojects/gst-plugins-bad/sys/mediafoundation/gstmfvideosrc.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/sys/mediafoundation/gstmfvideosrc.cpp b/subprojects/gst-plugins-bad/sys/mediafoundation/gstmfvideosrc.cpp index d909d07..81ae8f0 100644 --- a/subprojects/gst-plugins-bad/sys/mediafoundation/gstmfvideosrc.cpp +++ b/subprojects/gst-plugins-bad/sys/mediafoundation/gstmfvideosrc.cpp @@ -451,16 +451,20 @@ gst_mf_video_src_create (GstPushSrc * pushsrc, GstBuffer ** buffer) ret = GST_BASE_SRC_CLASS (parent_class)->alloc (GST_BASE_SRC (self), 0, GST_VIDEO_INFO_SIZE (&self->info), &buf); - if (ret != GST_FLOW_OK) + if (ret != GST_FLOW_OK) { + gst_clear_buffer (&buf); return ret; + } ret = gst_mf_source_object_fill (self->source, buf); } else { ret = gst_mf_source_object_create (self->source, &buf); } - if (ret != GST_FLOW_OK) + if (ret != GST_FLOW_OK) { + gst_clear_buffer (&buf); return ret; + } /* DirectShow capture object will set caps if it's got updated */ if (sample) { -- 2.7.4