From a363bfb986baf9f097c54f03def6a988d7b05ec8 Mon Sep 17 00:00:00 2001 From: Tomas Novotny Date: Wed, 16 Dec 2020 11:13:16 +0100 Subject: [PATCH] dt-bindings:iio:dac:microchip,mcp4725: fix properties for mcp4726 The vdd-supply property is optional if vref-supply is provided for mcp4726. Also the microchip,vref-buffered makes sense only if vref-supply is specified. Spotted by Jonathan during conversion to yaml. Reported-by: Jonathan Cameron Signed-off-by: Tomas Novotny Reviewed-by: Rob Herring Link: https://lore.kernel.org/r/20201216101316.1403-1-tomas@novotny.cz Signed-off-by: Jonathan Cameron --- .../bindings/iio/dac/microchip,mcp4725.yaml | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml index 2719986..5f5b578 100644 --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml @@ -39,20 +39,39 @@ properties: allOf: - if: - not: - properties: - compatible: - contains: - const: microchip,mcp4726 + properties: + compatible: + contains: + const: microchip,mcp4725 then: properties: vref-supply: false + required: + - vdd-supply + + - if: + properties: + compatible: + contains: + const: microchip,mcp4726 + then: + anyOf: + - required: + - vdd-supply + - required: + - vref-supply + + - if: + not: + required: + - vref-supply + then: + properties: microchip,vref-buffered: false required: - compatible - reg - - vdd-supply additionalProperties: false -- 2.7.4