From a36092f3f5b1bedce49b19b20b83e05f2bf19198 Mon Sep 17 00:00:00 2001 From: John Salem Date: Wed, 20 Feb 2019 12:22:24 -0800 Subject: [PATCH] Fix GC Hole by using SetAt on the PTRARRAY for the Assembly objects Commit migrated from https://github.com/dotnet/coreclr/commit/a63e6487936b54dd707636d8b8210dfd956f37d7 --- src/coreclr/src/vm/debugdebugger.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/src/vm/debugdebugger.cpp b/src/coreclr/src/vm/debugdebugger.cpp index a839340..a5cc9bc 100644 --- a/src/coreclr/src/vm/debugdebugger.cpp +++ b/src/coreclr/src/vm/debugdebugger.cpp @@ -519,8 +519,8 @@ FCIMPL4(void, DebugStackTrace::GetStackFramesInternal, pILI4[iNumValidFrames] = data.pElements[i].dwILOffset; // Assembly - OBJECTREF *pAssemblyArray = pStackFrameHelper->rgAssembly->GetDataPtr(); - pAssemblyArray[iNumValidFrames] = pFunc->GetAssembly()->GetDomainAssembly()->GetExposedAssemblyObject(); + OBJECTREF pAssembly = pFunc->GetAssembly()->GetDomainAssembly()->GetExposedAssemblyObject(); + pStackFrameHelper->rgAssembly->SetAt(iNumValidFrames, pAssembly); if (data.fDoWeHaveAnyFramesFromForeignStackTrace) { -- 2.7.4