From a2332425c4bd5581c6a25ba8a1c0b0a25865f269 Mon Sep 17 00:00:00 2001 From: Daniel Jasper Date: Fri, 30 May 2014 13:31:14 +0000 Subject: [PATCH] Revert "Remove redundant check discovered in post-commit review of r209505." This breaks with MSVC. With IsLateTemplateParsed, FunctionDecl::doesThisDeclarationHaveABody() returns true regardless of Body. This reinstates what was fixed in r208985. llvm-svn: 209896 --- clang-tools-extra/clang-tidy/misc/UseOverride.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp index 4e4ae27..628c20f 100644 --- a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp +++ b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp @@ -96,8 +96,10 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) { } } - if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody()) + if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() && + Method->getBody()) { InsertLoc = Method->getBody()->getLocStart(); + } if (!InsertLoc.isValid()) { if (Tokens.size() > 2 && GetText(Tokens.back(), Sources) == "0" && -- 2.7.4