From a0a02a7ad62b5615b17294c2075e4916f8d1f0a4 Mon Sep 17 00:00:00 2001 From: Akinobu Mita Date: Wed, 27 Jul 2011 11:00:36 +1000 Subject: [PATCH] md: use proper little-endian bitops Using __test_and_{set,clear}_bit_le() with ignoring its return value can be replaced with __{set,clear}_bit_le(). Signed-off-by: Akinobu Mita Cc: NeilBrown Cc: linux-raid@vger.kernel.org Signed-off-by: NeilBrown --- drivers/md/bitmap.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 574b09a..39ff0ef 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -932,7 +932,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block) if (bitmap->flags & BITMAP_HOSTENDIAN) set_bit(bit, kaddr); else - __test_and_set_bit_le(bit, kaddr); + __set_bit_le(bit, kaddr); kunmap_atomic(kaddr, KM_USER0); PRINTK("set file bit %lu page %lu\n", bit, page->index); } @@ -1304,8 +1304,10 @@ void bitmap_daemon_work(mddev_t *mddev) clear_bit(file_page_offset(bitmap, j), paddr); else - __test_and_clear_bit_le(file_page_offset(bitmap, j), - paddr); + __clear_bit_le( + file_page_offset(bitmap, + j), + paddr); kunmap_atomic(paddr, KM_USER0); } else log->type->clear_region(log, j); -- 2.7.4