From a0985821014a01db77d4401d3a965ad85cefb4c0 Mon Sep 17 00:00:00 2001 From: Mark Einon Date: Mon, 10 Oct 2011 16:22:32 +0100 Subject: [PATCH] staging: et131x: Update TODO list Added some more tasks to the TODO list, as highlighted by Francois Romieu . Signed-off-by: Mark Einon Signed-off-by: Greg Kroah-Hartman --- drivers/staging/et131x/README | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index d383e80..c67f83e 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. Based on the driver found at https://sourceforge.net/projects/et131x/ -Cleaned up immensely by Olaf Hartman and Christoph -Hellwig +Cleaned up immensely by Olaf Hartman and Christoph Hellwig Note, the powermanagement options were removed from the vendor provided driver as they did not build properly at the time. TODO: + - Put the driver into a single file, with a .h for the registers layout. + - rx_ring.fbr{0, 1} can probably share a common structure + - Use of kmem_cache seems a bit unusual + - Use dma_alloc_... in place of pci_alloc_... + - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. + - PCI_VDEVICE ? Please send patches to: Greg Kroah-Hartman -- 2.7.4