From a0067316e741e20e1ecbb01b3a3005fb64952eb7 Mon Sep 17 00:00:00 2001
From: Doug Nazar <nazard@nazar.ca>
Date: Sat, 24 Apr 2021 11:15:50 -0400
Subject: [PATCH] taglib: Update createFrame() to non-deprecated version.

ID3v2::FrameFactory::createFrame() versions not taking a Header have
been deprecated since v1.5 (Jan 2008).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/965>
---
 ext/taglib/gstid3v2mux.cc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/ext/taglib/gstid3v2mux.cc b/ext/taglib/gstid3v2mux.cc
index 487a6cf..2c34f17 100644
--- a/ext/taglib/gstid3v2mux.cc
+++ b/ext/taglib/gstid3v2mux.cc
@@ -391,8 +391,15 @@ add_id3v2frame_tag (ID3v2::Tag * id3v2tag, const GstTagList * list,
         GST_DEBUG ("Injecting ID3v2.%u frame %u/%u of length %" G_GSIZE_FORMAT " and type %"
             GST_PTR_FORMAT, version, i, num_tags, map.size, s);
 
+#if TAGLIB_MAJOR_VERSION > 1 || (TAGLIB_MAJOR_VERSION == 1 && TAGLIB_MINOR_VERSION >= 5)
+        ID3v2::Header header;
+        header.setMajorVersion (version);
+        frame = factory->createFrame (ByteVector ((const char *) map.data,
+                map.size), &header);
+#else
         frame = factory->createFrame (ByteVector ((const char *) map.data,
                 map.size), (TagLib::uint) version);
+#endif
         if (frame)
           id3v2tag->addFrame (frame);
 
@@ -586,7 +593,13 @@ add_uri_tag (ID3v2::Tag * id3v2tag, const GstTagList * list,
 
       g_free (data);
 
+#if TAGLIB_MAJOR_VERSION > 1 || (TAGLIB_MAJOR_VERSION == 1 && TAGLIB_MINOR_VERSION >= 5)
+      ID3v2::Header header;
+      header.setMajorVersion (4);
+      frame = factory->createFrame (bytes, &header);
+#else
       frame = factory->createFrame (bytes, (TagLib::uint) 4);
+#endif
       if (frame) {
         id3v2tag->addFrame (frame);
 
-- 
2.7.4