From 9fc6143a5b3fbfa44658836b60e85e4aaf0e0905 Mon Sep 17 00:00:00 2001 From: George Rimar Date: Thu, 8 Sep 2016 09:59:13 +0000 Subject: [PATCH] [ELF] - Add virtual destructor to LinkerScriptBase class. NFC. Absence of it caused a clang warning: warning: 'lld::elf::LinkerScriptBase' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] At fact we don't need it here because do not destroy this object by base pointer. llvm-svn: 280916 --- lld/ELF/LinkerScript.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lld/ELF/LinkerScript.h b/lld/ELF/LinkerScript.h index a3732ee..f62e5bd 100644 --- a/lld/ELF/LinkerScript.h +++ b/lld/ELF/LinkerScript.h @@ -125,6 +125,7 @@ struct PhdrsCommand { class LinkerScriptBase { public: + virtual ~LinkerScriptBase() = default; virtual uint64_t getOutputSectionAddress(StringRef Name) = 0; virtual uint64_t getOutputSectionSize(StringRef Name) = 0; virtual uint64_t getOutputSectionAlign(StringRef Name) = 0; -- 2.7.4