From 9f9b32dc5cf4e4a05eee73c2f7a238c9f3019899 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Thu, 2 Feb 2017 10:28:22 +0000 Subject: [PATCH] signals: Add some missing assertions to inline unit tests check_parse() can return NULL on OOM, which we might as well handle gracefully in the tests with an assertion, rather than an explosion. At least it will shut Coverity up. Coverity ID: 54724 Bug: https://bugs.freedesktop.org/show_bug.cgi?id=99643 Reviewed-by: Simon McVittie --- bus/signals.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bus/signals.c b/bus/signals.c index 838161f..6b7a464 100644 --- a/bus/signals.c +++ b/bus/signals.c @@ -2562,7 +2562,9 @@ test_equality (void) _dbus_assert (second_str != NULL); _dbus_assert (strcmp (first_str, second_str) == 0); first_reparsed = check_parse (TRUE, first_str); + _dbus_assert (first_reparsed != NULL); second_reparsed = check_parse (TRUE, second_str); + _dbus_assert (second_reparsed != NULL); _dbus_assert (match_rule_equal (first, first_reparsed)); _dbus_assert (match_rule_equal (second, second_reparsed)); bus_match_rule_unref (first_reparsed); @@ -2581,6 +2583,7 @@ test_equality (void) if (i != j) { second = check_parse (TRUE, equality_tests[j].second); + _dbus_assert (second != NULL); if (match_rule_equal (first, second)) { -- 2.7.4