From 9f80af930b76139fdb851708d70fa26ddf3ed09e Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Tue, 3 Jul 2018 13:32:02 +0300 Subject: [PATCH] contributing: about re-sending patches This is what is generally expected from people who re-send patches, whether the patches are their own or not. Signed-off-by: Pekka Paalanen Reviewed-by: Daniel Stone Reviewed-by: Derek Foreman --- CONTRIBUTING.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cbe02a3..9442d75 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -43,6 +43,14 @@ responsibility for the copyright status of the code. We won't reject patches that lack S-o-b, but it is strongly recommended. +When you re-send patches, revised or not, it would be very good to document the +changes compared to the previous revision in the commit message and/or the +cover letter. If you have already received Reviewed-by or Acked-by tags, you +should evaluate whether they still apply and include them in the respective +commit messages. Otherwise the tags may be lost, reviewers miss the credit they +deserve, and the patches may cause redundant review effort. + + Tracking patches and following up --------------------------------- -- 2.7.4