From 9f7896685fe212eb676313f1aad8e9f423edd5ff Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Fri, 21 Oct 2022 13:59:20 +0200 Subject: [PATCH] tu: Ignore line stipple dynamic state At least in the current Vulkan spec there is no validation language saying that it isn't valid to set this state if stippled lines aren't supported, so it seems we have to just ignore it. Ignore it if the user specifies a dynamic line stipple state and don't emit warnings if they call CmdSetLineStippleEXT because zink will do this. Part-of: --- src/freedreno/vulkan/tu_cmd_buffer.c | 1 - src/freedreno/vulkan/tu_pipeline.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/freedreno/vulkan/tu_cmd_buffer.c b/src/freedreno/vulkan/tu_cmd_buffer.c index a15055c..81fca21 100644 --- a/src/freedreno/vulkan/tu_cmd_buffer.c +++ b/src/freedreno/vulkan/tu_cmd_buffer.c @@ -3070,7 +3070,6 @@ tu_CmdSetLineStippleEXT(VkCommandBuffer commandBuffer, uint32_t lineStippleFactor, uint16_t lineStipplePattern) { - tu_stub(); } VKAPI_ATTR void VKAPI_CALL diff --git a/src/freedreno/vulkan/tu_pipeline.c b/src/freedreno/vulkan/tu_pipeline.c index eb77042..5f01383 100644 --- a/src/freedreno/vulkan/tu_pipeline.c +++ b/src/freedreno/vulkan/tu_pipeline.c @@ -3701,6 +3701,8 @@ tu_pipeline_builder_parse_dynamic(struct tu_pipeline_builder *builder, pipeline->dynamic_state_mask |= BIT(TU_DYNAMIC_STATE_VERTEX_INPUT) | BIT(TU_DYNAMIC_STATE_VB_STRIDE); break; + case VK_DYNAMIC_STATE_LINE_STIPPLE_EXT: + break; case VK_DYNAMIC_STATE_PATCH_CONTROL_POINTS_EXT: pipeline->dynamic_state_mask |= BIT(TU_DYNAMIC_STATE_PATCH_CONTROL_POINTS); -- 2.7.4