From 9f698822118682aacf3a6a958b621f0ef9053967 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 12 May 2017 12:08:32 -0400 Subject: [PATCH] ecore-wl2: do not offer a null mime first in ecore_wl2_offer_mimes_set() this seems to have been done to account for the case where no mimes were passed, but sending null in this way is bad behavior for a client. the spec indicates that null should be sent only when no mimes are accepted @fix --- src/lib/ecore_wl2/ecore_wl2_dnd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore_wl2/ecore_wl2_dnd.c b/src/lib/ecore_wl2/ecore_wl2_dnd.c index 830ca4e..76e1459 100644 --- a/src/lib/ecore_wl2/ecore_wl2_dnd.c +++ b/src/lib/ecore_wl2/ecore_wl2_dnd.c @@ -738,9 +738,10 @@ ecore_wl2_offer_mimes_set(Ecore_Wl2_Offer *offer, Eina_Array *mimes) { EINA_SAFETY_ON_NULL_RETURN(offer); - wl_data_offer_accept(offer->offer, offer->serial, NULL); if (mimes) eina_array_foreach(mimes, _emit_mime, offer); + else + wl_data_offer_accept(offer->offer, offer->serial, NULL); } typedef struct { -- 2.7.4