From 9f3edead9d959ab86265f8d8ca1750a8ddf7ae4e Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Tue, 21 Nov 2017 10:09:15 -0600 Subject: [PATCH] ecore_wl2: Fix buffer manager refcounting commit 0cf806005e32827f174f42cba27192c47ed9c4a7 correctly fixed a leaked buffer. However, other code was already accounting for the leaked reference to the buffer manager, so an extra deref happened and broke the universe - but only on hardware that no developer has access to for testing. --- src/lib/ecore_wl2/ecore_wl2_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/ecore_wl2/ecore_wl2_buffer.c b/src/lib/ecore_wl2/ecore_wl2_buffer.c index 3aabe46..8c4b0ff 100644 --- a/src/lib/ecore_wl2/ecore_wl2_buffer.c +++ b/src/lib/ecore_wl2/ecore_wl2_buffer.c @@ -583,7 +583,6 @@ _create_failed(void *data, struct zwp_linux_buffer_params_v1 *params) Ecore_Wl2_Display *ewd = data; zwp_linux_buffer_params_v1_destroy(params); - _buffer_manager_deref(); _buffer_manager_destroy(); ewd->wl.dmabuf = NULL; } -- 2.7.4