From 9f2b33e9e124c1a6be86fa83c21a1a8134a9ca10 Mon Sep 17 00:00:00 2001 From: Tanner Gooding Date: Fri, 29 Mar 2019 06:32:52 -0700 Subject: [PATCH] Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively (#23536) * Removing FeedTasksPackageVersion from dependencies.props * The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884 * Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively * Adding a ! in String.Searching.cs --- BuildToolsVersion.txt | 2 +- ILAsmVersion.txt | 2 +- dependencies.props | 11 +++-------- src/System.Private.CoreLib/shared/System/String.Searching.cs | 2 +- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/BuildToolsVersion.txt b/BuildToolsVersion.txt index c452d56..2dc3810 100644 --- a/BuildToolsVersion.txt +++ b/BuildToolsVersion.txt @@ -1 +1 @@ -3.0.0-preview1-03723-01 +3.0.0-preview4-03828-01 diff --git a/ILAsmVersion.txt b/ILAsmVersion.txt index 5967a38..abee55d 100644 --- a/ILAsmVersion.txt +++ b/ILAsmVersion.txt @@ -1 +1 @@ -3.0.0-preview4-27427-72 +3.0.0-preview4-27528-71 diff --git a/dependencies.props b/dependencies.props index fc82a23..130926c 100644 --- a/dependencies.props +++ b/dependencies.props @@ -26,13 +26,13 @@ - 9ff62111734d641ece5e5ccb873f2a463675d81b - 9ff62111734d641ece5e5ccb873f2a463675d81b + 79eb261c83005ea1c93c7861d374d1dd16a07353 + 79eb261c83005ea1c93c7861d374d1dd16a07353 - 3.0.0-preview4-27427-72 + 3.0.0-preview4-27528-71 2.4.1 1.0.0-beta-build0015 2.0.36 @@ -82,11 +82,6 @@ $(MSBuildThisFileDirectory)BuildToolsVersion.txt Microsoft.DotNet.BuildTools - - $(MSBuildThisFileFullPath) - FeedTasksPackageVersion - $(FeedTasksPackage) - File $(MSBuildThisFileDirectory)ILAsmVersion.txt diff --git a/src/System.Private.CoreLib/shared/System/String.Searching.cs b/src/System.Private.CoreLib/shared/System/String.Searching.cs index 49c0654..de91b3b 100644 --- a/src/System.Private.CoreLib/shared/System/String.Searching.cs +++ b/src/System.Private.CoreLib/shared/System/String.Searching.cs @@ -19,7 +19,7 @@ namespace System return SpanHelpers.IndexOf( ref _firstChar, Length, - ref value._firstChar, + ref value!._firstChar, // TODO-NULLABLE: Compiler Bug? value.Length) >= 0; } -- 2.7.4