From 9ed1f502fc538f592b885f5651d0aa4915c4486c Mon Sep 17 00:00:00 2001 From: Jeremy Kniager Date: Wed, 31 Oct 2018 16:36:15 -0600 Subject: [PATCH] cmake: Fix build crashing on make install Fixed make install crashing when running fixup_bundle on MacOS Change-Id: I2aee07c8a5235fcf2fc559d6d9774c48e1792e38 --- CMakeLists.txt | 2 ++ cube/CMakeLists.txt | 4 ++-- vulkaninfo/macOS/vulkaninfo.cmake | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ecd5af1..c163b18 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -85,7 +85,9 @@ endif() message(STATUS "Using find_package to locate Vulkan") find_package(Vulkan) find_package(VulkanHeaders) +get_filename_component(Vulkan_LIBRARY_DIR ${Vulkan_LIBRARY} DIRECTORY) message(STATUS "Vulkan FOUND = ${Vulkan_FOUND}") +message(STATUS "Vulkan Lib Dir = ${Vulkan_LIBRARY_DIR}") message(STATUS "Vulkan Lib = ${Vulkan_LIBRARY}") message(STATUS "Vulkan Headers Include = ${VulkanHeaders_INCLUDE_DIR}") message(STATUS "Vulkan Headers Registry = ${VulkanRegistry_DIR}") diff --git a/cube/CMakeLists.txt b/cube/CMakeLists.txt index 7481f38..67dff63 100644 --- a/cube/CMakeLists.txt +++ b/cube/CMakeLists.txt @@ -199,7 +199,7 @@ if(APPLE) # Fix up the library references to be self-contained within the bundle. install(CODE " include(BundleUtilities) - fixup_bundle(\${CMAKE_INSTALL_PREFIX}/cube/cube.app \"\" \"\") + fixup_bundle(\${CMAKE_INSTALL_PREFIX}/cube/cube.app \"\" \"${Vulkan_LIBRARY_DIR}\") ") else() install(TARGETS cube RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}) @@ -244,7 +244,7 @@ if(APPLE) # Fix up the library references to be self-contained within the bundle. install(CODE " include(BundleUtilities) - fixup_bundle(\${CMAKE_INSTALL_PREFIX}/cube/cubepp.app \"\" \"\") + fixup_bundle(\${CMAKE_INSTALL_PREFIX}/cube/cubepp.app \"\" \"${Vulkan_LIBRARY_DIR}\") ") else() install(TARGETS cubepp RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}) diff --git a/vulkaninfo/macOS/vulkaninfo.cmake b/vulkaninfo/macOS/vulkaninfo.cmake index 1927a38..3e325cb 100644 --- a/vulkaninfo/macOS/vulkaninfo.cmake +++ b/vulkaninfo/macOS/vulkaninfo.cmake @@ -68,5 +68,5 @@ install(TARGETS vulkaninfo-bundle BUNDLE DESTINATION "vulkaninfo") # script, which can't be fixed up. Instead pass it the explicit name of the executable. install(CODE " include(BundleUtilities) - fixup_bundle(\${CMAKE_INSTALL_PREFIX}/vulkaninfo/vulkaninfo.app/Contents/MacOS/vulkaninfo \"\" \"\") + fixup_bundle(\${CMAKE_INSTALL_PREFIX}/vulkaninfo/vulkaninfo.app/Contents/MacOS/vulkaninfo \"\" \"${Vulkan_LIBRARY_DIR}\") ") -- 2.7.4