From 9eb1b41811c76eec35c5feafb2fdc781f356bf48 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Wed, 25 Mar 2020 12:28:47 -0700 Subject: [PATCH] [llvm-cov] Improve error message for missing profdata I got a report recently that a user was having trouble interpreting the meaning of the error message. Hopefully this is more readable; produces something like the following: error: No such file or directory: Could not read profile data! Differential Revision: https://reviews.llvm.org/D76796 --- llvm/test/tools/llvm-cov/misssing-profdata.test | 2 ++ llvm/tools/llvm-cov/CodeCoverage.cpp | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 llvm/test/tools/llvm-cov/misssing-profdata.test diff --git a/llvm/test/tools/llvm-cov/misssing-profdata.test b/llvm/test/tools/llvm-cov/misssing-profdata.test new file mode 100644 index 0000000..44faeac --- /dev/null +++ b/llvm/test/tools/llvm-cov/misssing-profdata.test @@ -0,0 +1,2 @@ +RUN: not llvm-cov show -instr-profile=%t.nonexistent %t.nonexistent 2>&1 | FileCheck %s +CHECK: Could not read profile data diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index 625e234..b2024e9 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -867,8 +867,8 @@ int CodeCoverageTool::doShow(int argc, const char **argv, } sys::fs::file_status Status; - if (sys::fs::status(PGOFilename, Status)) { - error("profdata file error: can not get the file status. \n"); + if (std::error_code EC = sys::fs::status(PGOFilename, Status)) { + error("Could not read profile data!", EC.message()); return 1; } -- 2.7.4