From 9e708ac6b9929e9baa2017ff62f2353e6621a105 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Wed, 20 Jan 2021 11:16:01 -0800 Subject: [PATCH] [COFF] Fix relocation offsets in pdb-file-statics test input The relocation offsets were incorrect. I fixed them with llvm-readobj -codeview -codeview-subsection-bytes, which has a helpful printout of the relocations that apply to a given symbol record with their offsets. With this, I was able to update the relocation offsets in the yaml to fix the line table and the S_DEFRANGE_REGISTER records. There is still some remaining inconsistency in yaml2obj and obj2yaml when round tripping MSVC objects, but that isn't a blocker for relanding D94267. --- lld/test/COFF/Inputs/pdb-file-statics-a.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lld/test/COFF/Inputs/pdb-file-statics-a.yaml b/lld/test/COFF/Inputs/pdb-file-statics-a.yaml index 27e2ee1..8ece654 100644 --- a/lld/test/COFF/Inputs/pdb-file-statics-a.yaml +++ b/lld/test/COFF/Inputs/pdb-file-statics-a.yaml @@ -1591,16 +1591,16 @@ sections: - VirtualAddress: 154 SymbolName: main Type: IMAGE_REL_AMD64_SECTION - - VirtualAddress: 229 + - VirtualAddress: 222 SymbolName: main Type: IMAGE_REL_AMD64_SECREL - - VirtualAddress: 233 + - VirtualAddress: 226 SymbolName: main Type: IMAGE_REL_AMD64_SECTION - - VirtualAddress: 336 + - VirtualAddress: 328 SymbolName: main Type: IMAGE_REL_AMD64_SECREL - - VirtualAddress: 340 + - VirtualAddress: 332 SymbolName: main Type: IMAGE_REL_AMD64_SECTION - Name: .xdata -- 2.7.4