From 9e5bf10e212ee74074abf7ce19c115883d2e6e6c Mon Sep 17 00:00:00 2001 From: Bruce Ashfield Date: Thu, 23 Feb 2012 20:58:47 -0500 Subject: [PATCH] linux-yocto: improve checkout error handling and reporting The typical workflow for linux-yocto simply uses a remote upstream repository (Whether it is mirrored or not), and in this case there are no issues with consistency in the format of the resository that is unpacked into the WORKDIR. When working with a local linux-yocto repository for kernel development the remote vs local branches is not always consistent between repositories. The suggested/documented workflow has always been to use a bare clone of linux-yocto, and use a second working tree repository for development. Changes flow from the working tree to the bare clone and then into the working directory for build. A common mistake that happens with this workflow is that the non-bare, working repository is used instead of the bare clone version. If a non-bare repository is reference by the SRC_URI, then the branches that are fetched into WORKDIR are not consitent. If the MACHINE and META branches are not present, cryptic build errors will result. To solve this problem, the checkout code has been changed in several ways: - works with a newly proposed 'bareclone' option to bitbake - detects if a bareclone is present in WORKDIR or not and adjustst the checkout accordingly. - if a non-bare clone is detected, machine and meta branches are checked. If they are not present, or can't be created a clear error message is produced - instead of manipulating the refs directly in the git tree, local tracking branches are (quietly) created for remote branches. Enabling a better workflow in the WORKDIR kernel repository. This has been tested with linux-yocto remote upstreams, local bare and non-bare respositories. All builds succeed or fail with clear error messages. (From OE-Core rev: e3b6537cc7931636ab11ae6ed2c8fbaad9da91bc) Signed-off-by: Bruce Ashfield Signed-off-by: Richard Purdie --- meta/classes/kernel-yocto.bbclass | 72 ++++++++++++++++++++++++++------------- 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index 3130bf4..50ff555 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass @@ -139,33 +139,59 @@ do_patch() { } do_kernel_checkout() { - if [ -d ${WORKDIR}/git/.git/refs/remotes/origin ]; then - echo "Fixing up git directory for ${LINUX_KERNEL_TYPE}/${KMACHINE}" - rm -rf ${S} - mkdir ${S} + # we build out of {S}, so ensure that ${S} is clean and present + rm -rf ${S} + mkdir -p ${S}/.git + + set +e + + # A linux yocto SRC_URI should use the bareclone option. That + # ensures that all the branches are available in the WORKDIR version + # of the repository. If it wasn't passed, we should detect it, and put + # out a useful error message + if [ -d "${WORKDIR}/git/.git" ]; then + echo "WARNING. ${WORKDIR}/git is not a bare clone." + echo "Ensure that the SRC_URI includes the 'bareclone=1' option." + + # we can fix up the kernel repository, but at the least the meta + # branch must be present. The machine branch may be created later. mv ${WORKDIR}/git/.git ${S} - - if [ -e ${S}/.git/packed-refs ]; then - cd ${S} - rm -f .git/refs/remotes/origin/HEAD -IFS=' -'; - for r in `git show-ref | grep remotes`; do - ref=`echo $r | cut -d' ' -f1`; - b=`echo $r | cut -d' ' -f2 | sed 's%refs/remotes/origin/%%'`; - dir=`dirname $b` - mkdir -p .git/refs/heads/$dir - echo $ref > .git/refs/heads/$b - done - cd .. - else - cp -r ${S}/.git/refs/remotes/origin/* ${S}/.git/refs/heads - rmdir ${S}/.git/refs/remotes/origin + rm -rf ${WORKDIR}/git/ + cd ${S} + git branch -a | grep -q ${KMETA} + if [ $? -ne 0 ]; then + echo "ERROR. The branch '${KMETA}' is required and was not" + echo "found. Ensure that the SRC_URI points to a valid linux-yocto" + echo "kernel repository" + exit 1 fi + if [ -z "${YOCTO_KERNEL_EXTERNAL_BRANCH}" ]; then + git branch -a | grep -q ${KBRANCH} + if [ $? -ne 0 ]; then + echo "ERROR. The branch '${KBRANCH}' is required and was not" + echo "found. Ensure that the SRC_URI points to a valid linux-yocto" + echo "kernel repository" + exit 1 + fi + fi + else + mv ${WORKDIR}/git/* ${S}/.git + rm -rf ${WORKDIR}/git/ + cd ${S} + git config core.bare false fi - cd ${S} + # end debare - set +e + # convert any remote branches to local tracking ones + for i in `git branch -a | grep remotes | grep -v HEAD`; do + b=`echo $i | cut -d' ' -f2 | sed 's%remotes/origin/%%'`; + git show-ref --quiet --verify -- "refs/heads/$b" + if [ $? -ne 0 ]; then + git branch $b $i > /dev/null + fi + done + + # Create a working tree copy of the kernel by checkout out a branch git show-ref --quiet --verify -- "refs/heads/${KBRANCH}" if [ $? -eq 0 ]; then # checkout and clobber and unimportant files -- 2.7.4