From 9e4d51126f60264f53fbf841ef97092803e88374 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Tue, 4 Apr 2017 15:03:55 -0400 Subject: [PATCH] remove -mdspr2 I set -mdspr2 unconditionally on 32-bit MIPS builds only to not have to deal with setting it conditionally on the source files specifically requiring those instructions. Since then, I've deleted all the source files specifically requiring -mdspr2 (and -mdsp). No one understood them and they were only accelerating really uninteresting cases, like 565 blits. So, we haven't needed -mdspr2 anywhere for a while, and removing it will unblock running these builds on the CI20 dev boards, which support neither -mdsp nor -mdsp2. BUG=skia:1437 CQ_INCLUDE_TRYBOTS=skia.primary:Build-Ubuntu-Clang-mipsel-Debug-Android,Build-Ubuntu-Clang-mipsel-Release-Android Change-Id: Idda56fd8bb37ba064b78b4cddd8878b37dfe9502 Reviewed-on: https://skia-review.googlesource.com/11284 Commit-Queue: Mike Klein Reviewed-by: Derek Sollenberger Reviewed-by: Mike Klein --- gn/BUILD.gn | 1 - 1 file changed, 1 deletion(-) diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 52c13bf..95fb362 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -173,7 +173,6 @@ config("default") { cflags += [ "-no-integrated-as", # Clang <4.0 doesn't understand 'usw' mnemonic. "-march=mips32r2", - "-mdspr2", ] } else if (current_cpu == "x86" && !is_win) { asmflags += [ "-m32" ] -- 2.7.4