From 9e3dc66dbaa792145e53273228bfbaaa4d26d585 Mon Sep 17 00:00:00 2001 From: julie Date: Fri, 30 Jan 2015 07:26:22 +0000 Subject: [PATCH] Ed Anderson Bug Fix - Jan 26 2015 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In TESTING/LIN, the test routines xchkqr kept track of the number of tests performed in the variable NT, which could be 2, 6, or 7. Recently another test was added at the end and the loop that checks for failing tests was changed to run from 1 to NT to 1 to NTESTS, including tests that were never performed. As a result, with THRESH = 0., the number of tests failing exceeds the number of tests performed (for example, with n = 1 as the only N value and THRESH = 0.0 you get “604 out of 514 tests failed to pass the threshold”.) The right way to fix this would be to renumber the tests so that the new test is test #3 and the loop can run from 1 to NT again, but I just changed the count of tests performed from NT to NTESTS. For consistency between schkqr and schkrq and other test routines in the QR family, it would have been better for the new tests to go in a separate test module. --- TESTING/LIN/cchkqr.f | 2 +- TESTING/LIN/dchkqr.f | 2 +- TESTING/LIN/schkqr.f | 2 +- TESTING/LIN/zchkqr.f | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/TESTING/LIN/cchkqr.f b/TESTING/LIN/cchkqr.f index ed1d972..78958a0 100644 --- a/TESTING/LIN/cchkqr.f +++ b/TESTING/LIN/cchkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/dchkqr.f b/TESTING/LIN/dchkqr.f index 9ebbbc1..68118d2 100644 --- a/TESTING/LIN/dchkqr.f +++ b/TESTING/LIN/dchkqr.f @@ -439,7 +439,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/schkqr.f b/TESTING/LIN/schkqr.f index ea93673..4896342 100644 --- a/TESTING/LIN/schkqr.f +++ b/TESTING/LIN/schkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE diff --git a/TESTING/LIN/zchkqr.f b/TESTING/LIN/zchkqr.f index 38e704b..1cc39bb 100644 --- a/TESTING/LIN/zchkqr.f +++ b/TESTING/LIN/zchkqr.f @@ -438,7 +438,7 @@ NFAIL = NFAIL + 1 END IF 20 CONTINUE - NRUN = NRUN + NT + NRUN = NRUN + NTESTS 30 CONTINUE 40 CONTINUE 50 CONTINUE -- 2.7.4