From 9e1f5031ccda09da1b4e371850905adbac935956 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 30 Mar 2010 01:50:32 +0100 Subject: [PATCH] id3demux: fix parsing of unsynced frames with data length indicator Fixes bug #614158. --- gst/id3demux/id3v2frames.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gst/id3demux/id3v2frames.c b/gst/id3demux/id3v2frames.c index 79fdf61..021a3d1 100644 --- a/gst/id3demux/id3v2frames.c +++ b/gst/id3demux/id3v2frames.c @@ -116,9 +116,11 @@ id3demux_id3v2_parse_frame (ID3TagsWorking * work) } frame_data += 4; frame_data_size -= 4; - if (work->parse_size < frame_data_size) { - GST_WARNING ("ID3v2 frame %s has invalid size %d.", tag_name, - frame_data_size); + GST_LOG ("Un-unsynced data size %d (of %d)", work->parse_size, + frame_data_size); + if (work->parse_size > frame_data_size) { + GST_WARNING ("ID3v2 frame %s data has invalid size %d (>%d)", + work->frame_id, work->parse_size, frame_data_size); return FALSE; } } -- 2.7.4